Base generator #48
Merged
Base generator #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dimensions of __doc__ attribute from (1, height, width, n_channels) to (n_indexes, height, width, n_channels).
Fix dimensions of __doc__ attribute from (1, n_keypoints, 2) to (n_indexes, n_keypoints, 2).
|
Thanks, but should be |
|
Yes, even better.
…---
additional e-mail addresses:
urs.waldmann@daad-alumni.de
urs.waldmann@klasse2013.teachfirst.de
urs.waldmann@dav-ueberlingen.de
info@mv-waldmann.de
urs.waldmann@uni-konstanz.de
www.xing.com/profile/Urs_Waldmann
www.mv-waldmann.de
Gesendet: Freitag, 17. April 2020 um 10:10 Uhr
Von: "Jake Graving" <notifications@github.com>
An: "jgraving/DeepPoseKit" <DeepPoseKit@noreply.github.com>
Cc: "Urs Waldmann" <urs_waldmann@gmx.net>, "Author" <author@noreply.github.com>
Betreff: Re: [jgraving/DeepPoseKit] Base generator (#48)
Thanks, but should be n_samples rather than n_indexes
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Fix dimensions of __doc__ attribute from (n_indexes, height, width, n_channels) to (n_samples, height, width, n_channels).
Fix dimensions of __doc__ attribute from (n_indexes, n_keypoints, 2) to (n_samples, n_keypoints, 2).
|
I updated to n_samples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jake!
I think I found two minor fixes for the documentation of two functions in BaseGenerator.py. In general you can pass multiple indexes to get_images() and get_keypoints(). Therefore documentations should say dimension is (n_indexes, ...) instead of (1, ...) I guess.
Best,
Urs