Refactor of Writers/EPUB.hs #7991
Conversation
After a comment by JGM (jgm#1865 (comment)) we refactored EPUB.hs to make it more readable. More refactoring may be necessary, but this is probably a nice first step. Co-authored-by: Ola Wolska <A.k.wolska@student.tudelft.nl@gmail.com> Co-authored-by: Ivar de Bruin <ivardb@gmail.com> Co-authored-by: Jaap de Jong <jaapdejong15@gmail.com>
src/Text/Pandoc/Writers/EPUB.hs
Outdated
|
|
||
| -- | Splits the blocks into chapters and creates a corresponding reftable | ||
| createChaptersAndReftable :: WriterOptions -> [Block] -> ([Chapter], [(Text, Text)]) | ||
| createChaptersAndReftable opts secs = do |
There was a problem hiding this comment.
Why is this written with do notation? There is no monad. I think you could just write
createChaptersAndReftable opts secs = (chapters, reftable)
where
chapterHeaderLevel = ...
etc.
There was a problem hiding this comment.
Indeed, my mistake, it should be fixed now, let me know if you want us to combine the commits into one.
|
These look like good improvements in clarity (save the one thing I flagged in a comment). |
|
Thanks! I can squash the commits through the interface here. |
After a comment by JGM we refactored EPUB.hs to make it more readable. This includes adding more comments, splitting up the main conversion function (which was 500+ lines long). We think that readability is improved like this, but more refactoring may be necessary before the kindle writer will be worked on.
If you disagree with some of the changes, let us know!