Update revealjs template with newly available options #6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to use an option and realized that the default pandoc template didn't pass it through, so I went through and found all the options that Reveal.js advertises but that Pandoc's template doesn't support. <https://github.com/hakimel/reveal.js#configuration> I also noticed that rollingLinks isn't a setting anymore, but it's fine to keep it in the template because people might be using an old version of Reveal.js (via `revealjs-url`) that still has this option.
|
Thanks. In retrospect, I should probably have put all these variables under |
Yeah, it might pose potential problems; there's no real versioning built into the templates. Though it's probably something that can be put off until it manifests concretely as a problem (easier to solve a problem when you can see it!) By the way, if you have a second I'd love your input on the other PR I have open: #6342 Thanks again! Huge fan of pandoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use an option and realized that the default pandoc template
didn't pass it through, so I went through and found all the options that
Reveal.js advertises but that Pandoc's template doesn't support.
https://github.com/hakimel/reveal.js#configuration
I also noticed that rollingLinks isn't a setting anymore, but it's fine
to keep it in the template because people might be using an old version
of Reveal.js (via
revealjs-url) that still has this option.