Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown reader: handle inline code more eagerly within lists. #5628

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Markdown reader: handle inline code more eagerly within lists. #5628

merged 1 commit into from
Jul 6, 2019

Conversation

leungbk
Copy link
Contributor

@leungbk leungbk commented Jul 4, 2019

Closes #5627.

@leungbk
Copy link
Contributor Author

leungbk commented Jul 4, 2019

Found some oddball cases that weren't covered, I'll try to fix them up right now.

@leungbk leungbk changed the title Markdown reader: handle inline code more eagerly within lists. [WIP] Markdown reader: handle inline code more eagerly within lists. Jul 4, 2019
@leungbk leungbk changed the title [WIP] Markdown reader: handle inline code more eagerly within lists. Markdown reader: handle inline code more eagerly within lists. Jul 6, 2019
@leungbk
Copy link
Contributor Author

leungbk commented Jul 6, 2019

OK, this should be ready for review.

@jgm jgm merged commit 9c4ba81 into jgm:master Jul 6, 2019
@jgm
Copy link
Owner

jgm commented Jul 6, 2019

Great, thanks.

@leungbk leungbk deleted the markdownilc branch July 6, 2019 21:57
@jgm jgm mentioned this pull request Jun 11, 2024
Closed
jgm added a commit that referenced this pull request Mar 14, 2025
@jgm
Markdown reader: remove some misguided list fanciness.
28eca1e 
Previously we tried to handle things like commented out list
items:

    - one
    <!--
    - two
    -->
    - three

and also things like:

    - one `and
    - two` and

But the code we added to handle these cases caused problems with
other, more straightforward things, like:

    - one
    - ```
      code
      ```
    - three

So we are rolling back all the fanciness, so that the markdown
parser now behaves more like the commonmark parser, in which
indicators of block-level structure always take priority over
indicators of inline structure.

Closes #9865. Closes #7778. See also #5628.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fenced code blocks not escaped when converting Markdown to HTML5
2 participants
@leungbk @jgm