-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
add a fonts-as-attributes
option supported by the DOCX reader
#4474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dfd5005
to
e13f7bc
Compare
Just to let you know that i have reviewing this on my todo list, but it still might take a bit more time (until the end of the semester) until I have the time to fully think it through. @jgm: do you have any thoughts on this? It's accomodating broken word usage, but also probably pretty common usage. And we already, eg, read hand-indented paragraphs as block quotes, so there's precedent. Aesthetically I'm sort of against it, but practically, I guess if it doesn't affect normal performance I'd be for it. I imagine an extension would probably be better than an option. I'm almost tempted to fold this into +styles. (This is implying, after all, that fonts are a sort of ad-hoc character style in word.) |
I am not sure, I guess I don't have strong opinions. |
in my opinion there is no need to bind this option to the DOCX format, like it's currently the case for |
I wonder if |
e13f7bc
to
43ca45f
Compare
i renamed the option |
Hi all, i am looking at this again and wondering whether now it's a better time for reviewing. In order to support similar use cases, the only alternative i can imagine to this approach is to make this more generic, that means having an option that turns all children attributes into div attributes, maybe with a naming convention. This would be extremely ugly to read in a native representation and take a lot of space, but it would save us the complexity of adding new options or extensions for every interesting attribute in this specific format. Well this is kind of a strawman in order to imagine a better approach. I think that this goes in the direction of folding this into styles as proposed above by @jkr |
maybe the new name of the extension could refer to the non semantic nature of the additional attributes |
43ca45f
to
4c3c842
Compare
this pull request features a new reader option as discussed in the mailing list. i can improve the description in the manual if it doesn't explain the new option adequately.
i already tested this with a filter that allows me to format monospaced text as code. i developed this as an option but it could be an extension like
styles
, the criteria to distinguish between the two is not totally clear to me.