Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Fix BOOST_CHECK_THROW #57

Merged
merged 15 commits into from
Feb 3, 2019
Merged

Fix BOOST_CHECK_THROW #57

merged 15 commits into from
Feb 3, 2019

Conversation

maflcko
Copy link

@maflcko maflcko commented Dec 21, 2018

No description provided.

laanwj and others added 15 commits December 2, 2015 12:19
5668ca3 Return const references from getKeys, getValues, get_str (Wladimir J. van der Laan)
9f0b997 [travis] Work around osx libtool issue (MarcoFalke)
ba341a2 Add getObjMap() helper method.  Also, constify checkObject(). (Jeff Garzik)
ceb1194 Handle .pushKV() and .checkObject() edge cases. (Jeff Garzik)
107db98 Add ::push_back(double) method for feature parity. (Jeff Garzik)
d415300 Move one-line implementation of UniValue::read() to header. (Jeff Garzik)
52e85b3 Move exception-throwing get_* methods into separate implementation module. (Jeff Garzik)
dac5296 README.md: update code quotes (Jeff Garzik)
3e31dcf README.md: close code quote (Jeff Garzik)
d09b842 Update README.md (Jeff Garzik)
f1b86ed Convert README to markdown style. (Jeff Garzik)
1dfe464 Import UniValue class unit tests from bitcoin project. (Jeff Garzik)
0d3e74d operator[] takes size_t index parameter (versus unsigned int) (kozyilmaz)
640158f Private findKey() method becomes size_t clean, and returns bool on failure. (kozyilmaz)
4fd5444 Reject unterminated strings (Russell Yanofsky)
a31231b Version 1.0.3 (Jeff Garzik)
cfa0384 Convenience wrappers for push_back-ing integer types (isle2983)
fd32d1a Don't require nul-terminated string inputs (Russell Yanofsky)
0bb1439 Support parsing raw literals in UniValue (Russell Yanofsky)
839ccd7 Add test driver for JSONTestSuite (Russell Yanofsky)
a38fcd3 Do not shadow member variable codepoint. (Pavel Janík)
26ef3ff Remove trailing whitespace from JSON export (BtcDrak)

Pull request description:

  No rush, feel free to keep this open until upstream merged the outstanding pulls.

Tree-SHA512: f25fefc0319d8a02802fc802d75bada17ad583c81d92005947d93fb16ff7cff03b5fd92d986dccfec24cbfd13d87e08afef1efd6bac42ec0d57c6901930a5f50
…icit"

fe805ea Declare single-argument (non-converting) constructors "explicit" (practicalswift)

Pull request description:

  Rebased on #4.

  Closes #6, which stripped the original author.

Tree-SHA512: 4f4164fb1bbce54e5e28a5cf1327c4d7a2058e74384d1173de843acbfb71a3dc4a11e559650b86c6ac9063ea9c76c96fa371bff985d794c8dc904448f4ecd095
fa04209 Remove HomeBrew workaround (MarcoFalke)

Pull request description:

  This reverts 9f0b997

  For context: bitcoin-core#4 (comment)
  The workaround was causing issues. Rather than working around those as well,
  just revert it altogether.

Tree-SHA512: 1692c71fd2e1e79d9585689484eadb0fea6f75bd71c5cbbf50012fcca733ee5107ebcf6857b0065baa5f0ad73e41d0b488a1e7327196d9ea196d9e9f7c66badb
BOOST_CHECK_THROW doesn't correctly fail the test if no
exception is throw. Fix that (and add an assert message).

Bug and fix found by MarcoFalke.
ec849d9 [tests] Fix BOOST_CHECK_THROW macro (John Newbery)

Pull request description:

  BOOST_CHECK_THROW doesn't correctly fail the test if no
  exception is throw. Fix that (and add an assert message).

  Bug and fix found by MarcoFalke.

  @MarcoFalke

Tree-SHA512: 6920a5091cb432d6914b4f961ab398dfdbd5ae3f46831d164b2d3d65786c450b284ca0c3cd433a5402020d25191b00aaa76f302e3164b62092a75fbb1e8fee83
129bad9 [tests] test pushKV for boolean values (John Newbery)
b3c44c9 Pushing boolean value to univalue correctly (Karel Bilek)

Pull request description:

  Adds the new pushKV(key, boolean) function from #5, with test cases.

  Removal of srd::pair wrappers is in a future PR.

Tree-SHA512: d13b377365181723c06d4e4d7efa88f3cdbc6ca06ec2effe2ddf834bdfc7e602072c957296370323cb4e921a6934d55b040ebbdacca1dbff66e75d32073e6ac8
d208f98 Cleaned up namespace imports to reduce symbol collisions (Jason B. Cox)

Pull request description:

  Exact commit taken from #46 by jasonbcox

Tree-SHA512: 127db323530b03147d52de4107600024921f69756e0b2f0ecbb59f27f1783758a4d9016eb3b52c64170d03aa496c8b682affee171c51f86a4a4af6907b004b94
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants