Fix CMake install search location for libws2811.pc #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tells CMake to look for libws2811.pc in the correct location when this repo is a FetchContent subdirectory in a parent project.
|
Do |
|
No, I believe they have the same value when building an independent project, as the top level is the same as the current project in that case. However in the case of using FetchContent, it seems to create sub-directories in the build directory, and that causes the install step to fail as it's expecting |
|
Sounds rational. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue #448 that I was having.
Tells CMake to look for
libws2811.pcin the current binary dir rather than the top level binary dir. This allowsmake installto findlibws2811.pceven when the rpi_ws281x repo has been included as a FetchContent subdirectory in a parent project (see issue #448 ).I am by no means a CMake expert but this change seemed to make sense according to the documentation, fixes the FetchContent issue and I found no regression in the regular build process.
@flokli I think you wrote the original CMake code for libws2811.pc so including you here, hopefully the fix makes sense!