Clarify SPI timing issue for Pi 4 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess dynamically adjusting SPI speed based on CPU frequency can create offset and provide wrong timing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits the findings from #381 to the documentation.
The TLDR is that the Pi 4's idle frequency scaling affects SPI, and this is fundamentally incompatible with the extremely timing sensitive hack method of driving WS281x LEDs used in this library.
Perhaps it would be possible to detect the CPU scaling frequency and dynamically adjust the SPI speed, to avoid needing to clamp it. Though I would not venture this as a priority, since power is likely not an issue when driving strands of LEDs or LED displays.