Fix fread ignored result #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some compilers (e.g. gcc-7.4.0 on Ubuntu 18.04 aarch64) complain about the fact that fread()'s result is ignored. This breaks compilation. Fix this so that the library can be compiled with more compilers. This issue was found by a user who was accidentally(?) installing this library on NVIDIA Jetson. I haven't evaluated whether this library is useful on this platform, but there's no reason it should fail to compile there for such a generic issue. Besides, this fix will probably be useful on more relevant platforms if/when they upgrade their compilers.
swarren
force-pushed
the
fix-fread-ignored-result
branch
from
fe52cb8
to
71da385
Compare
|
@Gadgetoid dya know when you might be doing a sweep of this repo? |
|
@ladyada sorry, I've been buried in all manner of other projects and have let this slip somewhat. Don't hestitate to have someone give me a shout if anything is urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers (e.g. gcc-7.4.0 on Ubuntu 18.04 aarch64) complain about
the fact that fread()'s result is ignored. This breaks compilation. Fix
this so that the library can be compiled with more compilers.
This issue was found by a user who was accidentally(?) installing this
library on NVIDIA Jetson. I haven't evaluated whether this library is
useful on this platform, but there's no reason it should fail to compile
there for such a generic issue. Besides, this fix will probably be useful
on more relevant platforms if/when they upgrade their compilers.