-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic CMake support for master branch #353
base: master
Are you sure you want to change the base?
Conversation
Do you need a GetSources.cmake file? Can't you inline all that stuff in the main CMakeLists.txt script? |
Hopefully, those commits address your As for And lastly, |
The .pc file is for pkg-config |
Fix building on linux
pkg-config support has been added. I discovered some problems when building on Ubuntu 22.04, so I resolved those and then tested the pkg-config implementation. pkg-config seems to be finding liquid just fine. Hope that helps! :) |
@porkiedev have clone your branch. I run the following commands in msys2(mingW64) make: *** No targets specified and no makefile found. Stop. |
I don't currently have access to a PC, and this branch was from several months ago, so I can't investigate for about a week. Please ping me again if I don't reply again after a week, and I'll see what I can do. :) |
Thank your quickly reply. if there is no response, i will contact you. |
Sorry for the slow response. I can't remember for sure, but, if I recall correctly, I had issues with generating a makefile, which is why running |
Looking forward to CMake support, which would also make it easier to use Ninja! 🙏 |
|
I would also be really interested in finally adding CMake support to liquiddsp. It seems like this branch can be merged with the master one. I have been using it for a while with no problems. Big thanks to @porkiedev for the work. |
The more I have to deal with autotools, the more I think CMake support is really needed. |
Adds basic support for CMake. It's far from perfect but it does work.
This was heavily derived from the work done in #314 but with less complicated CPU feature detection and support for the latest master branch.
Unfortunately, this only builds the library. I am not a C programmer, nor do I have any experience with autotools or autotest.
Because of this, I couldn't implement and verify autotest functionality. I also couldn't implement benchmarks because I am building under MingW64 on Windows, and the
sys/resource.h
is not readily available.That said, this still builds the library fine and seems to be working. Hopefully, this motivates someone more qualified than me with CMake and C to build upon this work.