This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Revert "Fixed Path" #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added a commit
that referenced
this pull request
Sep 19, 2018
* Added support for file types across platforms (#26) * Added support for file types across platforms - Added per platform file type support, so you can specify what kind of files you want the picker to support - Updated iOS's picker to use the non-deprecated `UIDocumentPickerViewController` - Minor tweaks, such as package updates * Fixed an issue with the iOS implementation, where the returned path wasn't properly formatted/absolute, which in turn meant that the path wasn't valid as is. * A few iOS specific improvements * Get latest changes to master (#51) * pull master into develop before merging back (#47) * Resolved issues with referencing from NuGet package (#29) Simplified the nuspec file to work with wildcards and fixed macOS assembly name. Also added development NuGet feed to readme along with some other tweaks * Project fixes (#35) * fixed paths to NuGet packages folder; always relative to the .sln file * converted samples solution file to VS 2017 and fixed "Deploy" flag for Android app * ignore Android Resource designer generated files # Conflicts: # .gitignore * changes automatically applied by VS 2017 when opening iOS project file * Added issue template * fixes crash in Xamarin.Forms sample when user doesn't select file; also added example code in README file (#50) * fixed picking files from the download folder; on newer devices the document ID may not be a number, but the real filename prefixed with "raw:" (#49) * Updated dependencies * Revert "Fixed Path" (#65) * Revert "Fixed Path (#54)"
Merged
vividos
added a commit
that referenced
this pull request
Oct 25, 2018
…rted in PR #65); tested on iOS 11 device
jfversluis
pushed a commit
that referenced
this pull request
Oct 26, 2018
* Added support for file types across platforms (#26) * Added support for file types across platforms - Added per platform file type support, so you can specify what kind of files you want the picker to support - Updated iOS's picker to use the non-deprecated `UIDocumentPickerViewController` - Minor tweaks, such as package updates * Fixed an issue with the iOS implementation, where the returned path wasn't properly formatted/absolute, which in turn meant that the path wasn't valid as is. * A few iOS specific improvements * Get latest changes to master (#51) * pull master into develop before merging back (#47) * Resolved issues with referencing from NuGet package (#29) Simplified the nuspec file to work with wildcards and fixed macOS assembly name. Also added development NuGet feed to readme along with some other tweaks * Project fixes (#35) * fixed paths to NuGet packages folder; always relative to the .sln file * converted samples solution file to VS 2017 and fixed "Deploy" flag for Android app * ignore Android Resource designer generated files # Conflicts: # .gitignore * changes automatically applied by VS 2017 when opening iOS project file * Added issue template * fixes crash in Xamarin.Forms sample when user doesn't select file; also added example code in README file (#50) * fixed picking files from the download folder; on newer devices the document ID may not be a number, but the real filename prefixed with "raw:" (#49) * Updated dependencies * Revert "Fixed Path" (#65) * Revert "Fixed Path (#54)" * when opening files with the sample app, ignore if filename extension is uppercase or lowercase * removed unused method DidPickDocumentPicker() in iOS implementation * added troubleshooting chapter to readme with common errors and their solutions * updated sample projects to use PackageReference to reference NuGet packages * removed obsolete project property AndroidUseLatestPlatformSdk and set target framework to Android 9.0 (API 28) * updated Plugin.FilePicker.UWP to use PackageReference * removed obsolete property AndroidUseLatestPlatformSdk and target Android 9.0, in Plugin.FilePicker.Android project * updated sample projects to use Xamarin.Forms 3.3.0 NuGet package * updated UWP project to latest stable UWP NuGet package * fixed Android sample project by re-adding Xamarin.Forms NuGet package * added UWP sample project * find correct view controller to present document picker, by finding currently presented view controller * Android: return from task with Exception that was thrown during file picking before that, the caller only got a null FileData object without knowing what happened * Android: also pass exception to task when setting up picking * iOS: pass exceptions in DocumentPicker handler to picker task * renamed Forms project folder to a shorter name and renamed the only page to MainPage * added try-catch to call to PickFile() in order to display exceptions from picking * delete Resource.designer.cs file from repository that is being regenerated by the compiler * converted Xamarin.Forms sample project to use Project Sdk style .csproj proect file * added second button to samples to pick image files * added check if Android permission was granted * fix android mime types implementation (#85) (cherry picked from commit 04a5292) * added explanation for requesting permissions on Android (#89) * fixed exception when trying to pick a downloaded file; the Android DownloadManager won't return an actual file path; downloaded files can only be resolved using ContentResolver (#86) * added solution folders to organize projects * added UTType.Image file types value for picking on iOS * Forms sample project can use .NET Standard 1.0; no need for version 2.0, which might not be installed * added README.md for samples folder * added Plugin.Permissions NuGet package to sample project, in order to check for permissions * added checking Storage permission when on Android device * iOS: simplified getting filename from pathname * iOS: fixed getting pathname from FileUrl (fix of PR #54 that was reverted in PR #65); tested on iOS 11 device * added documentation about FileData class to README
jfversluis
pushed a commit
that referenced
this pull request
Oct 30, 2018
* Added support for file types across platforms (#26) * Added support for file types across platforms - Added per platform file type support, so you can specify what kind of files you want the picker to support - Updated iOS's picker to use the non-deprecated `UIDocumentPickerViewController` - Minor tweaks, such as package updates * Fixed an issue with the iOS implementation, where the returned path wasn't properly formatted/absolute, which in turn meant that the path wasn't valid as is. * A few iOS specific improvements * Get latest changes to master (#51) * pull master into develop before merging back (#47) * Resolved issues with referencing from NuGet package (#29) Simplified the nuspec file to work with wildcards and fixed macOS assembly name. Also added development NuGet feed to readme along with some other tweaks * Project fixes (#35) * fixed paths to NuGet packages folder; always relative to the .sln file * converted samples solution file to VS 2017 and fixed "Deploy" flag for Android app * ignore Android Resource designer generated files # Conflicts: # .gitignore * changes automatically applied by VS 2017 when opening iOS project file * Added issue template * fixes crash in Xamarin.Forms sample when user doesn't select file; also added example code in README file (#50) * fixed picking files from the download folder; on newer devices the document ID may not be a number, but the real filename prefixed with "raw:" (#49) * Updated dependencies * Revert "Fixed Path" (#65) * Revert "Fixed Path (#54)" * when opening files with the sample app, ignore if filename extension is uppercase or lowercase * removed unused method DidPickDocumentPicker() in iOS implementation * added troubleshooting chapter to readme with common errors and their solutions * updated sample projects to use PackageReference to reference NuGet packages * removed obsolete project property AndroidUseLatestPlatformSdk and set target framework to Android 9.0 (API 28) * updated Plugin.FilePicker.UWP to use PackageReference * removed obsolete property AndroidUseLatestPlatformSdk and target Android 9.0, in Plugin.FilePicker.Android project * updated sample projects to use Xamarin.Forms 3.3.0 NuGet package * updated UWP project to latest stable UWP NuGet package * fixed Android sample project by re-adding Xamarin.Forms NuGet package * added UWP sample project * find correct view controller to present document picker, by finding currently presented view controller * Android: return from task with Exception that was thrown during file picking before that, the caller only got a null FileData object without knowing what happened * Android: also pass exception to task when setting up picking * iOS: pass exceptions in DocumentPicker handler to picker task * renamed Forms project folder to a shorter name and renamed the only page to MainPage * added try-catch to call to PickFile() in order to display exceptions from picking * delete Resource.designer.cs file from repository that is being regenerated by the compiler * converted Xamarin.Forms sample project to use Project Sdk style .csproj proect file * added second button to samples to pick image files * added check if Android permission was granted * fix android mime types implementation (#85) (cherry picked from commit 04a5292) * added explanation for requesting permissions on Android (#89) * fixed exception when trying to pick a downloaded file; the Android DownloadManager won't return an actual file path; downloaded files can only be resolved using ContentResolver (#86) * added solution folders to organize projects * added UTType.Image file types value for picking on iOS * Forms sample project can use .NET Standard 1.0; no need for version 2.0, which might not be installed * added README.md for samples folder * added Plugin.Permissions NuGet package to sample project, in order to check for permissions * added checking Storage permission when on Android device * iOS: simplified getting filename from pathname * iOS: fixed getting pathname from FileUrl (fix of PR #54 that was reverted in PR #65); tested on iOS 11 device * added documentation about FileData class to README * Fix FileName for Mac FileName on Mac returned the path instead. * Fix OpenFile for Mac * fixed getting path from OneDrive (#79) the content provider only returned a relative filename in the data column, so it's better to use the content:// uri to access the file * fixed indentation of release notes text in .nuspec - it should look nice on the nuget.org page now * Android: file bytes are not read directly after picking, but only when FileData.DataArray is accessed or FileData.GetStream() is called; this fixes accessing large files that wouldn't fit in the device's memory, e.g. videos (#38) * iOS: also removed getting data bytes when it's not used in FilePickerEventArgs * added a troubleshooting section to explain why picked files on iOS may be gone after some time (#87, #74) * added SourceLink integration, see https://github.com/dotnet/sourcelink * added documentation for method PickFile(), in order to document how to use allowedTypes (#59) * Revert "added SourceLink integration, see https://github.com/dotnet/sourcelink" This reverts commit 1ca5796. * documented classes in Plugin.FilePicker.Abstractions and fixed line endings
jfversluis
pushed a commit
that referenced
this pull request
Nov 2, 2018
* Added support for file types across platforms (#26) * Added support for file types across platforms - Added per platform file type support, so you can specify what kind of files you want the picker to support - Updated iOS's picker to use the non-deprecated `UIDocumentPickerViewController` - Minor tweaks, such as package updates * Fixed an issue with the iOS implementation, where the returned path wasn't properly formatted/absolute, which in turn meant that the path wasn't valid as is. * A few iOS specific improvements * Get latest changes to master (#51) * pull master into develop before merging back (#47) * Resolved issues with referencing from NuGet package (#29) Simplified the nuspec file to work with wildcards and fixed macOS assembly name. Also added development NuGet feed to readme along with some other tweaks * Project fixes (#35) * fixed paths to NuGet packages folder; always relative to the .sln file * converted samples solution file to VS 2017 and fixed "Deploy" flag for Android app * ignore Android Resource designer generated files # Conflicts: # .gitignore * changes automatically applied by VS 2017 when opening iOS project file * Added issue template * fixes crash in Xamarin.Forms sample when user doesn't select file; also added example code in README file (#50) * fixed picking files from the download folder; on newer devices the document ID may not be a number, but the real filename prefixed with "raw:" (#49) * Updated dependencies * Revert "Fixed Path" (#65) * Revert "Fixed Path (#54)" * when opening files with the sample app, ignore if filename extension is uppercase or lowercase * removed unused method DidPickDocumentPicker() in iOS implementation * added troubleshooting chapter to readme with common errors and their solutions * updated sample projects to use PackageReference to reference NuGet packages * removed obsolete project property AndroidUseLatestPlatformSdk and set target framework to Android 9.0 (API 28) * updated Plugin.FilePicker.UWP to use PackageReference * removed obsolete property AndroidUseLatestPlatformSdk and target Android 9.0, in Plugin.FilePicker.Android project * updated sample projects to use Xamarin.Forms 3.3.0 NuGet package * updated UWP project to latest stable UWP NuGet package * fixed Android sample project by re-adding Xamarin.Forms NuGet package * added UWP sample project * find correct view controller to present document picker, by finding currently presented view controller * Android: return from task with Exception that was thrown during file picking before that, the caller only got a null FileData object without knowing what happened * Android: also pass exception to task when setting up picking * iOS: pass exceptions in DocumentPicker handler to picker task * renamed Forms project folder to a shorter name and renamed the only page to MainPage * added try-catch to call to PickFile() in order to display exceptions from picking * delete Resource.designer.cs file from repository that is being regenerated by the compiler * converted Xamarin.Forms sample project to use Project Sdk style .csproj proect file * added second button to samples to pick image files * added check if Android permission was granted * fix android mime types implementation (#85) (cherry picked from commit 04a5292) * added explanation for requesting permissions on Android (#89) * fixed exception when trying to pick a downloaded file; the Android DownloadManager won't return an actual file path; downloaded files can only be resolved using ContentResolver (#86) * added solution folders to organize projects * added UTType.Image file types value for picking on iOS * Forms sample project can use .NET Standard 1.0; no need for version 2.0, which might not be installed * added README.md for samples folder * added Plugin.Permissions NuGet package to sample project, in order to check for permissions * added checking Storage permission when on Android device * iOS: simplified getting filename from pathname * iOS: fixed getting pathname from FileUrl (fix of PR #54 that was reverted in PR #65); tested on iOS 11 device * added documentation about FileData class to README * Fix FileName for Mac FileName on Mac returned the path instead. * Fix OpenFile for Mac * fixed getting path from OneDrive (#79) the content provider only returned a relative filename in the data column, so it's better to use the content:// uri to access the file * fixed indentation of release notes text in .nuspec - it should look nice on the nuget.org page now * Android: file bytes are not read directly after picking, but only when FileData.DataArray is accessed or FileData.GetStream() is called; this fixes accessing large files that wouldn't fit in the device's memory, e.g. videos (#38) * iOS: also removed getting data bytes when it's not used in FilePickerEventArgs * added a troubleshooting section to explain why picked files on iOS may be gone after some time (#87, #74) * added SourceLink integration, see https://github.com/dotnet/sourcelink * added documentation for method PickFile(), in order to document how to use allowedTypes (#59) * Revert "added SourceLink integration, see https://github.com/dotnet/sourcelink" This reverts commit 1ca5796. * documented classes in Plugin.FilePicker.Abstractions and fixed line endings * added WPF sample project (#3) * implemented FilePicker for WPF (#64) * added detailed platforms where FilePicker can be used, in description (appears in NuGet package manager) and releaseNotes (appears on NuGet homepage) * added more designed generated files to ignore * forgot to add FilePicker WPF implementation to main solution * fixed OpenFile() call with relative filename that uses wrong parent directory (#71) * marked ReadFully() with Obsolete attribute; will be made internal in 2.1 * samples: added specifying file types for UWP platform * added or corrected documentation * Android: fixed stack overflow when calling OpenFile() with FileData argument
jfversluis
pushed a commit
that referenced
this pull request
Nov 26, 2018
* Added support for file types across platforms (#26) * Added support for file types across platforms - Added per platform file type support, so you can specify what kind of files you want the picker to support - Updated iOS's picker to use the non-deprecated `UIDocumentPickerViewController` - Minor tweaks, such as package updates * Fixed an issue with the iOS implementation, where the returned path wasn't properly formatted/absolute, which in turn meant that the path wasn't valid as is. * A few iOS specific improvements * Get latest changes to master (#51) * pull master into develop before merging back (#47) * Resolved issues with referencing from NuGet package (#29) Simplified the nuspec file to work with wildcards and fixed macOS assembly name. Also added development NuGet feed to readme along with some other tweaks * Project fixes (#35) * fixed paths to NuGet packages folder; always relative to the .sln file * converted samples solution file to VS 2017 and fixed "Deploy" flag for Android app * ignore Android Resource designer generated files # Conflicts: # .gitignore * changes automatically applied by VS 2017 when opening iOS project file * Added issue template * fixes crash in Xamarin.Forms sample when user doesn't select file; also added example code in README file (#50) * fixed picking files from the download folder; on newer devices the document ID may not be a number, but the real filename prefixed with "raw:" (#49) * Updated dependencies * Revert "Fixed Path" (#65) * Revert "Fixed Path (#54)" * when opening files with the sample app, ignore if filename extension is uppercase or lowercase * removed unused method DidPickDocumentPicker() in iOS implementation * added troubleshooting chapter to readme with common errors and their solutions * updated sample projects to use PackageReference to reference NuGet packages * removed obsolete project property AndroidUseLatestPlatformSdk and set target framework to Android 9.0 (API 28) * updated Plugin.FilePicker.UWP to use PackageReference * removed obsolete property AndroidUseLatestPlatformSdk and target Android 9.0, in Plugin.FilePicker.Android project * updated sample projects to use Xamarin.Forms 3.3.0 NuGet package * updated UWP project to latest stable UWP NuGet package * fixed Android sample project by re-adding Xamarin.Forms NuGet package * added UWP sample project * find correct view controller to present document picker, by finding currently presented view controller * Android: return from task with Exception that was thrown during file picking before that, the caller only got a null FileData object without knowing what happened * Android: also pass exception to task when setting up picking * iOS: pass exceptions in DocumentPicker handler to picker task * renamed Forms project folder to a shorter name and renamed the only page to MainPage * added try-catch to call to PickFile() in order to display exceptions from picking * delete Resource.designer.cs file from repository that is being regenerated by the compiler * converted Xamarin.Forms sample project to use Project Sdk style .csproj proect file * added second button to samples to pick image files * added check if Android permission was granted * fix android mime types implementation (#85) (cherry picked from commit 04a5292) * added explanation for requesting permissions on Android (#89) * fixed exception when trying to pick a downloaded file; the Android DownloadManager won't return an actual file path; downloaded files can only be resolved using ContentResolver (#86) * added solution folders to organize projects * added UTType.Image file types value for picking on iOS * Forms sample project can use .NET Standard 1.0; no need for version 2.0, which might not be installed * added README.md for samples folder * added Plugin.Permissions NuGet package to sample project, in order to check for permissions * added checking Storage permission when on Android device * iOS: simplified getting filename from pathname * iOS: fixed getting pathname from FileUrl (fix of PR #54 that was reverted in PR #65); tested on iOS 11 device * added documentation about FileData class to README * Fix FileName for Mac FileName on Mac returned the path instead. * Fix OpenFile for Mac * fixed getting path from OneDrive (#79) the content provider only returned a relative filename in the data column, so it's better to use the content:// uri to access the file * fixed indentation of release notes text in .nuspec - it should look nice on the nuget.org page now * Android: file bytes are not read directly after picking, but only when FileData.DataArray is accessed or FileData.GetStream() is called; this fixes accessing large files that wouldn't fit in the device's memory, e.g. videos (#38) * iOS: also removed getting data bytes when it's not used in FilePickerEventArgs * added a troubleshooting section to explain why picked files on iOS may be gone after some time (#87, #74) * added SourceLink integration, see https://github.com/dotnet/sourcelink * added documentation for method PickFile(), in order to document how to use allowedTypes (#59) * Revert "added SourceLink integration, see https://github.com/dotnet/sourcelink" This reverts commit 1ca5796. * documented classes in Plugin.FilePicker.Abstractions and fixed line endings * added WPF sample project (#3) * implemented FilePicker for WPF (#64) * added detailed platforms where FilePicker can be used, in description (appears in NuGet package manager) and releaseNotes (appears on NuGet homepage) * added more designed generated files to ignore * forgot to add FilePicker WPF implementation to main solution * fixed OpenFile() call with relative filename that uses wrong parent directory (#71) * marked ReadFully() with Obsolete attribute; will be made internal in 2.1 * samples: added specifying file types for UWP platform * added or corrected documentation * Android: fixed stack overflow when calling OpenFile() with FileData argument * marked FileData as sealed; no use deriving from FileData * reformatting C# files; no real code changes - formatted files with Visual Studio editor to fix spaces and line endings - added xml documentation - added this. for accessing fields and properties and for calling methods - sorted and removed unused usings * changed sample solution configuration so that Any CPU also compiles on UWP x86 and targets iOS iPhone * updated Resource.designer.cs file for Forms sample * removed property FileByte from internal class FilePickerEventArgs, as it is never used * using Intent Extra constant for passing allowed types to FilePickerActivity, instead of using nameof() * added pull request template, adapted from the Xamarin.Forms github project * When Android doesn't have Permission.ReadExternalStorage the App will now ask the user to grant the permission on API level >=23 * Added necessary imports * Added requested fix of inverted if's to get the right action when permission is granted * Added comment for REQUEST_STORAGE * Changed variable to PascalCase * cleaning up code from PR #109 * Revert "added checking Storage permission when on Android device" This reverts commit 779c5a1. * Revert "added Plugin.Permissions NuGet package to sample project, in order to check for permissions" This reverts commit e81ed29. * removed compiler warnings in Mac implementation * permission READ_EXTERNAL_STORAGE is automatically added to the Android app that uses this plugin; no need to add it to AndroidManifest.xml now (#112) * removed READ_EXTERNAL_STORE permission from sample project
jfversluis
pushed a commit
that referenced
this pull request
Nov 28, 2018
* Added support for file types across platforms (#26) * Added support for file types across platforms - Added per platform file type support, so you can specify what kind of files you want the picker to support - Updated iOS's picker to use the non-deprecated `UIDocumentPickerViewController` - Minor tweaks, such as package updates * Fixed an issue with the iOS implementation, where the returned path wasn't properly formatted/absolute, which in turn meant that the path wasn't valid as is. * A few iOS specific improvements * Get latest changes to master (#51) * pull master into develop before merging back (#47) * Resolved issues with referencing from NuGet package (#29) Simplified the nuspec file to work with wildcards and fixed macOS assembly name. Also added development NuGet feed to readme along with some other tweaks * Project fixes (#35) * fixed paths to NuGet packages folder; always relative to the .sln file * converted samples solution file to VS 2017 and fixed "Deploy" flag for Android app * ignore Android Resource designer generated files # Conflicts: # .gitignore * changes automatically applied by VS 2017 when opening iOS project file * Added issue template * fixes crash in Xamarin.Forms sample when user doesn't select file; also added example code in README file (#50) * fixed picking files from the download folder; on newer devices the document ID may not be a number, but the real filename prefixed with "raw:" (#49) * Updated dependencies * Revert "Fixed Path" (#65) * Revert "Fixed Path (#54)" * when opening files with the sample app, ignore if filename extension is uppercase or lowercase * removed unused method DidPickDocumentPicker() in iOS implementation * added troubleshooting chapter to readme with common errors and their solutions * updated sample projects to use PackageReference to reference NuGet packages * removed obsolete project property AndroidUseLatestPlatformSdk and set target framework to Android 9.0 (API 28) * updated Plugin.FilePicker.UWP to use PackageReference * removed obsolete property AndroidUseLatestPlatformSdk and target Android 9.0, in Plugin.FilePicker.Android project * updated sample projects to use Xamarin.Forms 3.3.0 NuGet package * updated UWP project to latest stable UWP NuGet package * fixed Android sample project by re-adding Xamarin.Forms NuGet package * added UWP sample project * find correct view controller to present document picker, by finding currently presented view controller * Android: return from task with Exception that was thrown during file picking before that, the caller only got a null FileData object without knowing what happened * Android: also pass exception to task when setting up picking * iOS: pass exceptions in DocumentPicker handler to picker task * renamed Forms project folder to a shorter name and renamed the only page to MainPage * added try-catch to call to PickFile() in order to display exceptions from picking * delete Resource.designer.cs file from repository that is being regenerated by the compiler * converted Xamarin.Forms sample project to use Project Sdk style .csproj proect file * added second button to samples to pick image files * added check if Android permission was granted * fix android mime types implementation (#85) (cherry picked from commit 04a5292) * added explanation for requesting permissions on Android (#89) * fixed exception when trying to pick a downloaded file; the Android DownloadManager won't return an actual file path; downloaded files can only be resolved using ContentResolver (#86) * added solution folders to organize projects * added UTType.Image file types value for picking on iOS * Forms sample project can use .NET Standard 1.0; no need for version 2.0, which might not be installed * added README.md for samples folder * added Plugin.Permissions NuGet package to sample project, in order to check for permissions * added checking Storage permission when on Android device * iOS: simplified getting filename from pathname * iOS: fixed getting pathname from FileUrl (fix of PR #54 that was reverted in PR #65); tested on iOS 11 device * added documentation about FileData class to README * Fix FileName for Mac FileName on Mac returned the path instead. * Fix OpenFile for Mac * fixed getting path from OneDrive (#79) the content provider only returned a relative filename in the data column, so it's better to use the content:// uri to access the file * fixed indentation of release notes text in .nuspec - it should look nice on the nuget.org page now * Android: file bytes are not read directly after picking, but only when FileData.DataArray is accessed or FileData.GetStream() is called; this fixes accessing large files that wouldn't fit in the device's memory, e.g. videos (#38) * iOS: also removed getting data bytes when it's not used in FilePickerEventArgs * added a troubleshooting section to explain why picked files on iOS may be gone after some time (#87, #74) * added SourceLink integration, see https://github.com/dotnet/sourcelink * added documentation for method PickFile(), in order to document how to use allowedTypes (#59) * Revert "added SourceLink integration, see https://github.com/dotnet/sourcelink" This reverts commit 1ca5796. * documented classes in Plugin.FilePicker.Abstractions and fixed line endings * added WPF sample project (#3) * implemented FilePicker for WPF (#64) * added detailed platforms where FilePicker can be used, in description (appears in NuGet package manager) and releaseNotes (appears on NuGet homepage) * added more designed generated files to ignore * forgot to add FilePicker WPF implementation to main solution * fixed OpenFile() call with relative filename that uses wrong parent directory (#71) * marked ReadFully() with Obsolete attribute; will be made internal in 2.1 * samples: added specifying file types for UWP platform * added or corrected documentation * Android: fixed stack overflow when calling OpenFile() with FileData argument * marked FileData as sealed; no use deriving from FileData * reformatting C# files; no real code changes - formatted files with Visual Studio editor to fix spaces and line endings - added xml documentation - added this. for accessing fields and properties and for calling methods - sorted and removed unused usings * changed sample solution configuration so that Any CPU also compiles on UWP x86 and targets iOS iPhone * updated Resource.designer.cs file for Forms sample * removed property FileByte from internal class FilePickerEventArgs, as it is never used * using Intent Extra constant for passing allowed types to FilePickerActivity, instead of using nameof() * added pull request template, adapted from the Xamarin.Forms github project * When Android doesn't have Permission.ReadExternalStorage the App will now ask the user to grant the permission on API level >=23 * Added necessary imports * Added requested fix of inverted if's to get the right action when permission is granted * Added comment for REQUEST_STORAGE * Changed variable to PascalCase * cleaning up code from PR #109 * Revert "added checking Storage permission when on Android device" This reverts commit 779c5a1. * Revert "added Plugin.Permissions NuGet package to sample project, in order to check for permissions" This reverts commit e81ed29. * removed compiler warnings in Mac implementation * permission READ_EXTERNAL_STORAGE is automatically added to the Android app that uses this plugin; no need to add it to AndroidManifest.xml now (#112) * removed READ_EXTERNAL_STORE permission from sample project * fixed file mode for several files; no actual code changes old mode: 100755, new mode 100644 changed using the commands: git config core.filemode true chmod -R -x . see also: https://stackoverflow.com/questions/1257592/ git also reports some files have all their lines changed * Update README.md * Multi targeting (#116) * added multi-targeting project Plugin.FilePicker changed solution to only include one project renamed all shared, abstraction and implementation files according to their platforms removed platform specific .csproj files removed AssemblyInfo.cs and resources; infos now also in .csproj new project generated by jamesmontemagno's "Cross-Platform .NET Standard Plugin Templates" project template see: https://marketplace.visualstudio.com/items?itemName=vs-publisher-473885.PluginForXamarinTemplates * updated sample projects to use multi-targeting project updated solution files with single new csproj file replaced direct references from sample platform project to plugin platform project with reference to multi-targeting project * made FilePickerEventArgs and FilePickerCancelledEventArgs internal * made ReadFully() internal and removed Obsolete attribute * Revert "Merge branch 'master' into develop" This reverts commit ea8feba, reversing changes made to 752f6b6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #54