Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for expiring token and access token config #155

Merged
merged 8 commits into from
Feb 27, 2024
Merged

Add support for expiring token and access token config #155

merged 8 commits into from
Feb 27, 2024

Conversation

alexhung
Copy link
Member

  • Add support for username specific config path
  • Add support for using refresh token for user token path
  • Add automatic token refresh if access token expires
  • Fix ttl, and max ttl logic and applies them to token expiration
  • Update README with more detailed documentation for all paths

@alexhung
Clean up code and move paths to constants
b93ce28
@alexhung
Add optional username path and field to user token config
ee12429 
Store user config base on path

Add support for using refresh token to renew an existing access token
@alexhung
Add refresh_token field to user token config
4203a57 
Add check for expired token error

Add refresh token attempt then retry token creation
@alexhung
DRY the configuration between admin and user
007403e 
Add 'url' and 'bypass_artifactory_tls_verification' fields to user token config.
@alexhung
Change how token expires_in is set via Role object
bd746d2 
Now use an ephemeral field in Role object 'ExpiresIn' instead of 'MaxTTL'.

User token now use TTL (with heuristics) for token expires_in
@alexhung
Move BypassArtifactoryTLSVerification field back to adminConfiguration
680ac0b
@alexhung
Update README with reference documentation for all paths
48ee680 
Update path descriptions and field descriptions.
@alexhung alexhung added the enhancement New feature or request label Feb 23, 2024
@alexhung alexhung requested a review from danielmkn February 23, 2024 19:50
@alexhung alexhung marked this pull request as ready for review February 23, 2024 20:03
danielmkn
danielmkn previously approved these changes Feb 26, 2024
View reviewed changes
@alexhung alexhung requested a review from danielmkn February 27, 2024 00:10
@alexhung alexhung linked an issue Feb 27, 2024 that may be closed by this pull request
include_reference_token and refreshable not working when configured by default #154
Closed
@alexhung alexhung merged commit 031f95d into master Feb 27, 2024
2 checks passed
@alexhung alexhung deleted the add-support-for-expiring-token-and-access-token-config branch February 27, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkn danielmkn danielmkn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include_reference_token and refreshable not working when configured by default
2 participants
@alexhung @danielmkn