Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI to 1.46.4 #33

Merged
merged 7 commits into from
Apr 19, 2021
Merged

Update CLI to 1.46.4 #33

merged 7 commits into from
Apr 19, 2021

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Apr 6, 2021 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.
  • Upgrade CLI to 1.46.4
  • Upgrade minimal CLI version to 1.45.0, due to the new configuration command.
  • Download CLI from 'releases.jfrog.io' instead of Bintray - fix tests.
  • Update config import command to match the required in the latest versions.

@yahavi yahavi requested a review from eyalbe4 April 6, 2021 12:36
@yahavi yahavi self-assigned this Apr 6, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@yahavi yahavi marked this pull request as draft April 7, 2021 05:38
eyalbe4
eyalbe4 suggested changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If needed, let's release jfrog-cli 1.46.2 and use it in this action, so that it includes jfrog/jfrog-cli-core#107 and jfrog/jfrog-cli#1048

@yahavi yahavi changed the title Update CLI to 1.46.1 Update CLI to 1.46.4 Apr 19, 2021
@yahavi yahavi marked this pull request as ready for review April 19, 2021 12:39
eyalbe4
eyalbe4 suggested changes Apr 19, 2021
View reviewed changes
@yahavi yahavi merged commit 93bc26f into jfrog:master Apr 19, 2021
@yahavi yahavi deleted the update-cli branch April 19, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4