Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload - Add timezone to each zip file before uploading #2103

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Upload - Add timezone to each zip file before uploading #2103

merged 4 commits into from
Sep 27, 2023

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Jul 31, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

By uploading files with archive as zip, the timezone offset is not saved.
This PR checks that each file has the correct timezone.

Dependent on:

@Or-Geva Or-Geva added the bug Something isn't working label Jul 31, 2023
@Or-Geva Or-Geva requested a review from talarian1 July 31, 2023 09:01
@Or-Geva Or-Geva mentioned this pull request Jul 31, 2023
Merged
4 tasks
@Or-Geva Or-Geva requested a review from eyalbe4 July 31, 2023 09:01
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@Or-Geva Or-Geva temporarily deployed to frogbot September 27, 2023 06:32 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@Or-Geva Or-Geva removed the bug Something isn't working label Sep 27, 2023
@Or-Geva Or-Geva added the ignore for release Automatically generated release notes label Sep 27, 2023
@Or-Geva Or-Geva merged commit c958add into jfrog:dev Sep 27, 2023
57 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talarian1 talarian1 talarian1 approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Or-Geva @talarian1