-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptor to results #73
Draft
attiasas
wants to merge
17
commits into
jfrog:dev
Choose a base branch
from
attiasas:add_descriptor_to_results
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
improvement
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
labels
Jun 2, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.Refactor
Results
-->ScanCommandResults
audit=working-dir
,scan=binary-file
,docker scan=binary-file
,build-scan=build name + number
)Aditional changes
Restructure repository packages and code
TechnologyHadler
interface will help support new technologies and maintain them in all of our commandsEnrich SCA results in
Sarif
formatartifactLocation.uri
for all scan commands and mThis PR:
softwarecomponents
not related to commands.Result
object ability to group SCA results per descriptor file.Tech Root Node
->Descriptor File Node
->Descriptor Dependencies
This is not a complete implementation of all the features needed to process the descriptor files. missing: