-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoapods support for audit #196
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, take a look at my comments:
- Add integration tests to
artifactory_test.go
- Add integraion tests to
audit_test.go
- Add screen shot of the table results running on a cocoapods project to the PR details
utils/techutils/techutils.go
Outdated
Java CodeLanguage = "java" | ||
CSharp CodeLanguage = "C#" | ||
CPP CodeLanguage = "C++" | ||
CocoapodsLang CodeLanguage = "any" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why its any
? is it not used for objective C
/ swift
languages?
Is there a Cocoapods
Lang that is used in the files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cocoapods actually houses packages built with many languages, not just ObjC / Swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add this as a comment above.
Change the name of the const to Any
/ Multiple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this? why is missing-context
related to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be removed from PR
} | ||
|
||
func GetDependenciesData(exePath, currentDir string) (string, error) { | ||
_, _, err := cocoapods.RunPodCmd(exePath, currentDir, []string{"install"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to install everytime? what if the user already have Podfile.lock
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add a test to skip installation if Podfile.lock
exists and has newer ModTime than Podfile
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
dev
branch.go vet ./...
.go fmt ./...
.Description:
jf audit for cocoapods package manager
Depends on:
jfrog/jfrog-cli-core#1274
audit example on nanopb package in a cocoapods project:
Minimum pod version - 1.15.2