-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail 'jf scan' when a wrong flag is provided after command's arguments #165
base: dev
Are you sure you want to change the base?
Fail 'jf scan' when a wrong flag is provided after command's arguments #165
Conversation
…with arguments that have been provided in an incorrect order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, take a look at my comments
…o fix-scan-ignored-flags-issue
…o fix-scan-ignored-flags-issue
…o fix-scan-ignored-flags-issue
@@ -196,7 +196,13 @@ func EnrichCmd(c *components.Context) error { | |||
func ScanCmd(c *components.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does docker scan uses the same flow as ScanCmd
? or should implement it there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is using dockerCmd that resides in CLI. I initiated another PR to ecosystem:
jfrog/jfrog-cli#2686
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hadarshjfrog Since resolving the same issue in 'jf docker scan' should be done by Ecosystem and this is not a top priority for them. Since this is not going to happen soon and I dont want to miss the fix Iv'e already worked on im proceeding without 'jf docker scan' and we can open a ticket for the Ecosystem about this
Please add integration tests you think might simulate it - with the common mistakes we have seen (flags at the end instead of beginning, |
…o fix-scan-ignored-flags-issue # Conflicts: # utils/utils.go
…o fix-scan-ignored-flags-issue
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
dev
branch.go vet ./...
.go fmt ./...
.The 'jf scan' command should be executed in the following manner: jf scan [command options]