Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit SCA recursive scan #994

Merged
merged 33 commits into from
Nov 5, 2023
Merged

Audit SCA recursive scan #994

merged 33 commits into from
Nov 5, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 15, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

depends on: jfrog/jfrog-client-go#850

Recursive Technology Detection to Identify All Projects in the Current Working Directory

image

We are introducing a new parameter to the Sca Audit command:

  • exclusions - You can specify exclusion patterns (wildcards) for files that should not be included in the mapping when detecting technologies, if not specified it will use the default exclusions set: ["*node_modules*", "*target*", "*venv*", "*test*"]

These parameters and capabilities will integrate with existing options as follows:

  • workingDir - If it doesn't exist, it will recursively detect the projects (and technologies) inside the current directory. If at least one value exists, it will perform technology detection only on the given directories without recursion.
  • Technologies flags (--npm, --maven, etc.) - If a specific technology flag is specified but not detected, it will only scan the root (the given working directory) with that technology.

These changes enhance the functionality of the Audit command, making it more flexible and capable of detecting technologies recursively when needed.

@attiasas attiasas added the improvement Automatically generated release notes label Oct 15, 2023
@attiasas attiasas changed the title Start implement recursive scan Audit recursive scan Oct 15, 2023
@eyalbe4 eyalbe4 added new feature Automatically generated release notes and removed improvement Automatically generated release notes labels Oct 31, 2023
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add enhance JFrog CLI's documentation in https://github.com/jfrog/documentation with the new options and functionality added by this PR.
There's no need yo update the documentation under https://github.com/jfrog/jfrog-cli/tree/v2/documentation anymore.

utils/coreutils/techutils.go Outdated Show resolved Hide resolved
utils/coreutils/techutils.go Outdated Show resolved Hide resolved
utils/coreutils/techutils.go Show resolved Hide resolved
utils/coreutils/techutils.go Show resolved Hide resolved
utils/coreutils/techutils.go Show resolved Hide resolved
utils/coreutils/techutils.go Outdated Show resolved Hide resolved
xray/commands/audit/scarunner.go Show resolved Hide resolved
xray/commands/audit/scarunner.go Outdated Show resolved Hide resolved
xray/commands/audit/scarunner.go Show resolved Hide resolved
xray/commands/audit/scarunner.go Outdated Show resolved Hide resolved
@attiasas attiasas merged commit 7296ed5 into jfrog:dev Nov 5, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants