Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer - Show delayed files #980

Merged
merged 8 commits into from
Oct 15, 2023
Merged

Transfer - Show delayed files #980

merged 8 commits into from
Oct 15, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 28, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Progressbar:
image

Status:
image

@yahavi yahavi self-assigned this Sep 28, 2023
@yahavi yahavi added the improvement Automatically generated release notes label Sep 28, 2023
@yahavi yahavi marked this pull request as ready for review October 2, 2023 09:27
@yahavi yahavi requested a review from eyalbe4 October 2, 2023 09:27
eyalbe4
eyalbe4 requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the following comment right after the "Delayed files" value in the --startus display, to explain what "Delayed files" are:

De;ayed files:        100 (Files to be transferred last, after all other files.)

@yahavi yahavi requested a review from eyalbe4 October 12, 2023 15:13
@yahavi yahavi temporarily deployed to frogbot October 15, 2023 09:11 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@yahavi yahavi merged commit c31b1b6 into jfrog:dev Oct 15, 2023
8 checks passed
@yahavi yahavi deleted the transfer-delayed branch October 15, 2023 09:23
@chenrui333 chenrui333 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4