Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set analyzer manager version by environment variable #935

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Set analyzer manager version by environment variable #935

merged 4 commits into from
Sep 7, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Sep 5, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Use JFROG_CLI_ANALYZER_MANAGER_VERSION to set analyzer manager version

@sverdlov93
copy dir
31f360f 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Sep 5, 2023
attiasas
attiasas approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe we can use it in our integrations tests to see if the latest ([RELEASE] value) analyzer manager is breaking us

@sverdlov93
copy dir
57e5653 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
copy dir
99c209f 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit fd00f19 into jfrog:dev Sep 7, 2023
7 of 8 checks passed
@p-linnane p-linnane mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @attiasas