Feature/app 1726 Support overwrite strategy flag from CLI #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
asafgabai
reviewed
Feb 1, 2026
Collaborator
asafgabai
left a comment
asafgabai
left a comment
There was a problem hiding this comment.
As this is a public PR, let's change its title to a more descriptive one. A description is also recommended.
Comment on lines
20
to
22
| OverwriteStrategyDisabled = "DISABLED" | ||
| OverwriteStrategyLatest = "LATEST" | ||
| OverwriteStrategyAll = "ALL" |
Collaborator
There was a problem hiding this comment.
Other enums in our CLI are lowercase. Can we make it lowercase too? Does RLM accept only uppercase values?
Collaborator
Author
There was a problem hiding this comment.
Done, I changed to lowercase, and I move them to uppercase just before handing them to the request body
apptrust/commands/flags.go
Outdated
| ExcludeReposFlag: components.NewStringFlag(ExcludeReposFlag, "Semicolon-separated list of repositories to exclude.", func(f *components.StringFlag) { f.Mandatory = false }), | ||
| IncludeReposFlag: components.NewStringFlag(IncludeReposFlag, "Semicolon-separated list of repositories to include.", func(f *components.StringFlag) { f.Mandatory = false }), | ||
| PropsFlag: components.NewStringFlag(PropsFlag, "Semicolon-separated list of properties in the form of 'key1=value1;key2=value2;...' to be added to each artifact.", func(f *components.StringFlag) { f.Mandatory = false }), | ||
| OverwriteStrategyFlag: components.NewStringFlag(OverwriteStrategyFlag, "The overwrite strategy. The following values are supported: "+coreutils.ListToText(model.OverwriteStrategyValues), func(f *components.StringFlag) { f.Mandatory = false }), |
Collaborator
There was a problem hiding this comment.
I recommend adding a more detailed description of this flag
Collaborator
Author
There was a problem hiding this comment.
Improved the help text
shayshim
force-pushed
the
feature/APP-1726
branch
from
8733a54 to
dfc5e23
Compare
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
shayshim
changed the title
asafgabai
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch.go vet ./....go fmt ./....