-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize to latest versions supported by Java 8 #841
base: master
Are you sure you want to change the base?
Modernize to latest versions supported by Java 8 #841
Conversation
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePluginForJava8?organizationId=SmVua2lucyBDSQ%3D%3D Co-authored-by: Moderne <team@moderne.io>
Remove custom configuration and rely on Jenkins tooling for config
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA
|
recheck |
@yahavi I saw you merged a recent PR, would you be able to look at this one or point me to someone who could? It'd be great to modernize this important plugin so it didn't install so many implicit plugin dependencies |
I think this PR could have been prevented #845 |
@sghill-rewrite It looks like some of the integration tests are failing with:
|
Thanks for taking a look @yahavi! Looks like these integration tests require some extra setup. Any advice on running them locally so I can debug? I was able to run some of the DeclarativeITest suite setup locally, but most tests were skipped due to missing environment variables. I suppose those need to point to running services? I did notice the logs included that parameterized-trigger must be updated to run with the git plugin, but I don't see parameterized-trigger referenced in the project. |
Related to #847 |
Hey @sghill! I was trying to change as little as possible on my PR. |
Sounds great @rahulsom! Happy to rebase here when that's ready or break this down into smaller PRs |
Hi!
This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big. If this goes well, I can follow up with a subsequent PR to modernize further.
This PR was generated with an OpenRewrite recipe on Moderne.io.
Additionally I enabled maven enforcer by adding the required excludes and relying on the parent POM's enforcer config.
passed.