-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add https_proxy and no_proxy configurations to the Maven repository resolution #725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the suggested changes. I'd like to review it again before merging.
Also:
- Run reformat on all files before submitting a PR
- I added some coding-style comments that may be applied to other added code locations
- Avoid using "Boolean" unless it is really needed
...xtractor/src/main/java/org/jfrog/build/extractor/clientConfiguration/client/ManagerBase.java
Outdated
Show resolved
Hide resolved
build-info-client/src/main/java/org/jfrog/build/client/JFrogHttpClient.java
Outdated
Show resolved
Hide resolved
build-info-client/src/main/java/org/jfrog/build/client/PreemptiveHttpClientBuilder.java
Show resolved
Hide resolved
.../main/java/org/jfrog/build/extractor/clientConfiguration/ArtifactoryClientConfiguration.java
Outdated
Show resolved
Hide resolved
.../main/java/org/jfrog/build/extractor/clientConfiguration/ArtifactoryClientConfiguration.java
Outdated
Show resolved
Hide resolved
String HTTPS = "https"; | ||
String NO_PROXY_DOMAIN = "noProxyDomain"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that work if we have both HTTP_PROXY and HTTPS_PROXY environment variables in the JFrog CLI?
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
…s. Use proxy selector for maven deployment
proxy.setPort(resolutionHelper.getProxyPort()); | ||
proxy.setUserName(resolutionHelper.getProxyUsername()); | ||
proxy.setPassword(resolutionHelper.getProxyPassword()); | ||
ArtifactoryPluginResolution artifactoryResolution = new ArtifactoryPluginResolution(resolutionHelper.getRepoReleaseUrl(), resolutionHelper.getRepoSnapshotUrl(), resolutionHelper.getRepoUsername(), resolutionHelper.getRepoPassword(), proxySelector, new NullPlexusLog()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing a null logger may hide some valuable information. Can we use a regular log or use an adapter to our logger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RemovedNullPlexusLog()
in flavor of resolutionHelper.getLogger()
With this PR, HTTP proxy functions will be extended to support HTTPS-proxy and no-proxy domains in the maven repository resolution functions.
Related to: