Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OCI package type #386 #387

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Add support for OCI package type #386 #387

merged 2 commits into from
Sep 2, 2024

Conversation

jcoste-orange
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jcoste-orange
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jcoste-orange jcoste-orange mentioned this pull request Jul 17, 2024
Closed
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jul 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 17, 2024
@jcoste-orange
Copy link
Contributor Author

I don't understand why some tests are failling as they are not related to the pull request.

Did someone has an idea ?

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Aug 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 26, 2024
yahavi
yahavi requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @jcoste-orange!
Please consider my inline comments.

...a/org/jfrog/artifactory/client/model/repository/settings/impl/OciRepositorySettingsImpl.java Outdated Show resolved Hide resolved
...a/org/jfrog/artifactory/client/model/repository/settings/impl/OciRepositorySettingsImpl.java Outdated Show resolved Hide resolved
...a/org/jfrog/artifactory/client/model/repository/settings/impl/OciRepositorySettingsImpl.java Outdated Show resolved Hide resolved
@jcoste-orange
Copy link
Contributor Author

@yahavi I push a new commit to take into account your review.

@yahavi yahavi added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 2, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 2, 2024
yahavi
yahavi approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, @jcoste-orange!

@yahavi yahavi merged commit fce2baa into jfrog:dev Sep 2, 2024
7 checks passed
@yahavi
Copy link
Member

yahavi commented Sep 2, 2024

@jcoste-orange
Artifactory Java client version 2.18.0 has been released and is anticipated to be available on Maven Central within a few hours.
Please feel welcome to share your feedback here.

@jonesbusy
Copy link
Contributor

Thanks! I think we miss also the 'helmoci' repo which should be also similar to the "generic" OCI type

@jonesbusy jonesbusy mentioned this pull request Sep 14, 2024
Merged
2 tasks
@yahavi yahavi linked an issue Oct 3, 2024 that may be closed by this pull request
Add support for OCI package type #386
Closed
@yahavi yahavi removed a link to an issue Oct 3, 2024
Add support for OCI package type #386
Closed
@yahavi
Copy link
Member

yahavi commented Oct 3, 2024 •
edited
Loading

@jonesbusy
Artifactory Java client version 2.19.0 has been released, featuring your fix for this issue.
Kindly let us know if that resolved the issue.

@yahavi yahavi linked an issue Oct 3, 2024 that may be closed by this pull request
Add support for OCI package type #386
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OCI package type
3 participants
@jcoste-orange @yahavi @jonesbusy