Removed stale translation and improved set_setting translation at H…

…ome Connect (home-assistant#129878)
jfparis · Nov 5, 2024 · b71c437 · b71c437
1 parent d671341
commit b71c437
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/homeassistant/components/home_connect/strings.json b/homeassistant/components/home_connect/strings.json
@@ -37,11 +37,8 @@
     "set_light_color": {
       "message": "Error while trying to set color of {entity_id}: {description}"
     },
-    "set_light_effect": {
-      "message": "Error while trying to set effect of {entity_id}: {description}"
-    },
     "set_setting": {
-      "message": "Error while trying to set \"{value}\" to \"{key}\" setting for {entity_id}: {description}"
+      "message": "Error while trying to assign the value \"{value}\" to the setting \"{key}\" for {entity_id}: {description}"
     },
     "turn_on": {
       "message": "Error while trying to turn on {entity_id} ({key}): {description}"

diff --git a/tests/components/home_connect/test_number.py b/tests/components/home_connect/test_number.py
@@ -161,7 +161,9 @@ async def test_number_entity_error(
     with pytest.raises(HomeConnectError):
         getattr(problematic_appliance, mock_attr)()
 
-    with pytest.raises(ServiceValidationError, match=r"Error.*set.*setting.*"):
+    with pytest.raises(
+        ServiceValidationError, match=r"Error.*assign.*value.*to.*setting.*"
+    ):
         await hass.services.async_call(
             NUMBER_DOMAIN,
             SERVICE_SET_VALUE,

diff --git a/tests/components/home_connect/test_time.py b/tests/components/home_connect/test_time.py
@@ -135,7 +135,9 @@ async def test_time_entity_error(
     with pytest.raises(HomeConnectError):
         getattr(problematic_appliance, mock_attr)()
 
-    with pytest.raises(ServiceValidationError, match=r"Error.*set.*setting.*"):
+    with pytest.raises(
+        ServiceValidationError, match=r"Error.*assign.*value.*to.*setting.*"
+    ):
         await hass.services.async_call(
             TIME_DOMAIN,
             SERVICE_SET_VALUE,