Skip to content

Commit

Permalink
Add quality scale for weheat (home-assistant#135384)
Browse files Browse the repository at this point in the history
  • Loading branch information
jesperraemaekers authored Jan 13, 2025
1 parent c489f94 commit 4ddb723
Show file tree
Hide file tree
Showing 4 changed files with 96 additions and 5 deletions.
96 changes: 96 additions & 0 deletions homeassistant/components/weheat/quality_scale.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
rules:
# Bronze
action-setup:
status: exempt
comment: No service actions currently available
appropriate-polling: done
brands: done
common-modules: done
config-flow-test-coverage: done
config-flow: done
dependency-transparency: done
docs-actions: done
docs-high-level-description: done
docs-installation-instructions: done
docs-removal-instructions: done
entity-event-setup:
status: exempt
comment: |
No explicit event subscriptions.
entity-unique-id: done
has-entity-name: done
runtime-data: done
test-before-configure:
status: todo
comment: |
There are two servers that are used for this integration.
If the authentication server is unreachable, the user will not pass the configuration step.
If the backend is unreachable, an empty error message is displayed.
test-before-setup: done
unique-config-entry: done

# Silver
action-exceptions:
status: exempt
comment: No service actions currently available
config-entry-unloading: done
docs-configuration-parameters:
status: exempt
comment: |
No configuration parameters available.
docs-installation-parameters: done
entity-unavailable: done
integration-owner: done
log-when-unavailable: done
parallel-updates:
status: todo
comment: |
PARALLEL_UPDATES is not set.
reauthentication-flow: done
test-coverage: done

# Gold
devices: done
diagnostics: todo
discovery-update-info:
status: exempt
comment: |
This integration is a cloud service and thus does not support discovery.
discovery:
status: exempt
comment: |
This integration is a cloud service and thus does not support discovery.
docs-data-update: done
docs-examples: todo
docs-known-limitations: done
docs-supported-devices: done
docs-supported-functions: todo
docs-troubleshooting: done
docs-use-cases: todo
dynamic-devices:
status: todo
comment: |
While unlikely to happen. Check if it is easily integrated.
entity-category: todo
entity-device-class: done
entity-disabled-by-default: todo
entity-translations: done
exception-translations: todo
icon-translations: done
reconfiguration-flow:
status: exempt
comment: |
There is no reconfiguration, as the only configuration step is authentication.
repair-issues:
status: exempt
comment: |
This is a cloud service and apart form reauthentication there are not user repairable issues.
stale-devices:
status: todo
comment: |
While unlikely to happen. Check if it is easily integrated.
# Platinum
async-dependency: todo
inject-websession: todo
strict-typing: todo
1 change: 0 additions & 1 deletion script/hassfest/quality_scale.py
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,6 @@ class Rule:
"weatherflow_cloud",
"weatherkit",
"webmin",
"weheat",
"wemo",
"whirlpool",
"whois",
Expand Down
2 changes: 0 additions & 2 deletions tests/components/weheat/test_binary_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from unittest.mock import AsyncMock, patch

from freezegun.api import FrozenDateTimeFactory
import pytest
from syrupy import SnapshotAssertion
from weheat.abstractions.discovery import HeatPumpDiscovery
Expand Down Expand Up @@ -40,7 +39,6 @@ async def test_create_binary_entities(
mock_weheat_heat_pump: AsyncMock,
mock_heat_pump_info: HeatPumpDiscovery.HeatPumpInfo,
mock_config_entry: MockConfigEntry,
freezer: FrozenDateTimeFactory,
) -> None:
"""Test creating entities."""
mock_weheat_discover.return_value = [mock_heat_pump_info]
Expand Down
2 changes: 0 additions & 2 deletions tests/components/weheat/test_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from unittest.mock import AsyncMock, patch

from freezegun.api import FrozenDateTimeFactory
import pytest
from syrupy import SnapshotAssertion
from weheat.abstractions.discovery import HeatPumpDiscovery
Expand Down Expand Up @@ -41,7 +40,6 @@ async def test_create_entities(
mock_weheat_heat_pump: AsyncMock,
mock_heat_pump_info: HeatPumpDiscovery.HeatPumpInfo,
mock_config_entry: MockConfigEntry,
freezer: FrozenDateTimeFactory,
has_dhw: bool,
nr_of_entities: int,
) -> None:
Expand Down

0 comments on commit 4ddb723

Please sign in to comment.