Address code review suggestions

.ci/verify

@@ -1,11 +1,16 @@
 #!/bin/bash
 
+set -o errexit
+set -o nounset
+set -o pipefail
+
 cd "$(dirname $0)/.."
 
 git config --global user.email "gardener@sap.com"
 git config --global user.name "Gardener CI/CD"
 
-apt-get update && apt-get install -y unzip
+apt-get update
+apt-get install -y unzip
 
 mkdir -p /go/src/github.com/gardener/gardener
 cp -r . /go/src/github.com/gardener/gardener

.gitignore

@@ -27,6 +27,3 @@ config.vmdk
 # Virtual go & fuse
 .virtualgo
 .fuse_hidden*
-
-# Packr generated files
-*-packr.go

Makefile

@@ -126,11 +126,11 @@ docker-push:
 
 .PHONY: install-requirements
 install-requirements:
-	@go install -mod=vendor github.com/gobuffalo/packr/v2/packr2
 	@go install -mod=vendor github.com/onsi/ginkgo/ginkgo
 	@go install -mod=vendor github.com/ahmetb/gen-crd-api-reference-docs
-	@go get github.com/golang/mock/mockgen
+	@go install -mod=vendor github.com/golang/mock/mockgen
 	@GO111MODULE=off go get github.com/prometheus/prometheus/cmd/promtool
+	@go get golang.org/x/tools/cmd/goimports
 	@./hack/install-requirements.sh
 
 .PHONY: revendor

docs/README.md

@@ -59,6 +59,7 @@
   * [Shoot resource customization webhooks](extensions/shoot-webhooks.md)
   * [Logging and Monitoring configuration](extensions/logging-and-monitoring.md)
   * [Contributing to shoot health status conditions](extensions/shoot-health-status-conditions.md)
+    * [Health Check Library](extensions/healthcheck-library.md)
   * Blob storage providers
     * [`BackupBucket` resource](extensions/backupbucket.md)
     * [`BackupEntry` resource](extensions/backupentry.md)

docs/extensions/shoot-health-status-conditions.md

@@ -82,4 +82,4 @@ status:
 ```
 
 Hence, the only duty extensions have is to maintain the health status of their components in the extension resource they are managing.
-This can be accomplished using the [health check library for extensions](https://github.com/gardener/gardener/blob/master/extensions/docs/healthcheck-library.md).
+This can be accomplished using the [health check library for extensions](https://github.com/gardener/gardener/blob/master/docs/extensions/healthcheck-library.md).

extensions/README.md

@@ -1,6 +1,6 @@
 # [Gardener Extensions Library](https://gardener.cloud)
 
-![Gardener Extensions Logo](../logo/gardener-extension-180px.png)
+![Gardener Extensions Logo](../logo/gardener-extension-large.png)
 
 Project Gardener implements the automated management and operation of [Kubernetes](https://kubernetes.io/) clusters as a service. Its main principle is to leverage Kubernetes concepts for all of its tasks.
 
@@ -13,20 +13,47 @@ Please consult https://github.com/gardener/gardener/tree/master/docs/extensions
 
 Check out these repositories for implementations of the Gardener Extension contracts:
 
-| Infrastructure Provider | DNS Provider | Operating System | Container Runtime | Network Plugin | Generic Extensions |
-| ----------------------- | ------------ | ---------------- | ------------------| -------------- | ------------------ |
-| [Alicloud](https://github.com/gardener/gardener-extension-provider-alicloud) | [External DNS Management](https://github.com/gardener/external-dns-management) [*]| [CoreOS/FlatCar](https://github.com/gardener/gardener-extension-os-coreos) | [gVisor](https://github.com/gardener/gardener-extension-runtime-gvisor) | [Calico](https://github.com/gardener/gardener-extension-networking-calico) | [Shoot DNS service](https://github.com/gardener/gardener-extension-shoot-dns-service) |
-| [AWS](https://github.com/gardener/gardener-extension-provider-aws) | | [CoreOS/FlatCar (Alicloud)](https://github.com/gardener/gardener-extension-os-coreos-alicloud) | | [Cilium](https://github.com/gardener/gardener-extension-networking-cilium) | [Shoot Certificate Service](https://github.com/gardener/gardener-extension-shoot-cert-service)
-| [Azure](https://github.com/gardener/gardener-extension-provider-azure) | | [GardenLinux](https://github.com/gardener/gardener-extension-os-gardenlinux) | | |
-| [GCP](https://github.com/gardener/gardener-extension-provider-gcp) | | [Debian/Ubuntu (MetalStack)](https://github.com/metal-stack/os-metal-extension) | | |
-| [MetalStack](https://github.com/metal-stack/gardener-extension-provider-metal) | | [SuSE JeOS](https://github.com/gardener/gardener-extension-os-suse-jeos) | | |
-| [Mock / Local](https://github.com/gardener/gardener-extension-provider-mock) | | [Ubuntu](https://github.com/gardener/gardener-extension-os-ubuntu) | | |
-| [OpenStack](https://github.com/gardener/gardener-extension-provider-openstack) | | [Ubuntu (Alicloud)](https://github.com/gardener/gardener-extension-os-ubuntu-alicloud) | | |
-| [Packet](https://github.com/gardener/gardener-extension-provider-packet) | | | |
-| [vSphere](https://github.com/gardener/gardener-extension-provider-vsphere) | | | |
+### Infrastructure Provider
+
+- [Alicloud](https://github.com/gardenergardener-extension-provider-alicloud) - optional description goes here
+- [AWS](https://github.com/gardenergardener-extension-provider-aws)
+- [Azure](https://github.com/gardenergardener-extension-provider-azure)
+- [GCP](https://github.com/gardenergardener-extension-provider-gcp)
+- [MetalStack](https://github.com/metal-podgardener-extension-provider-metal)
+- [OpenStack](https://github.com/gardenergardener-extension-provider-openstack)
+- [Packet](https://github.com/gardenergardener-extension-provider-packet)
+- [vSphere](https://github.com/gardenergardener-extension-provider-vsphere)
+
+### DNS Provider
+
+- [External DNS Management](https://github.com/gardener/external-dns-management) [*]
 
 <sub>[*] Alicoud DNS, AWS Route53, Azure DNS, Cloudflare DNS, Google CloudDNS, OpenStack Designate</sub>
 
+### Operating System
+
+- [CoreOS/FlatCar](https://github.com/gardener/gardener-extension-os-coreos)
+- [CoreOS/FlatCar (Alicloud)](https://github.com/gardener/gardener-extension-os-coreos-alicloud)
+- [GardenLinux](https://github.com/gardener/gardener-extension-os-gardenlinux)
+- [Debian/Ubuntu (MetalStack)](https://github.com/metal-pod/os-metal-extension)
+- [Ubuntu](https://github.com/gardener/gardener-extension-os-ubuntu)
+- [Ubuntu (Alicloud)](https://github.com/gardener/gardener-extension-os-ubuntu-alicloud)
+- [SuSE JeOS](https://github.com/gardener/gardener-extension-os-suse-jeos)
+
+### Container Runtime
+
+- [gVisor](https://github.com/gardener/gardener-extension-runtime-gvisor)
+
+### Network Plugin
+
+- [Calico](https://github.com/gardener/gardener-extension-networking-calico)
+- [Cilium](https://github.com/gardener/gardener-extension-networking-cilium)
+
+### Generic Extensions
+
+- [Shoot Certificate Service](https://github.com/gardener/gardener-extension-shoot-cert-service)
+- [Shoot DNS Service](https://github.com/gardener/gardener-extension-shoot-dns-service)
+
 If you implemented a new extension, please feel free to add it to this list!
 
 ## Feedback and Support

extensions/hack/tools.go

@@ -16,9 +16,3 @@
 
 // This package imports things required by build scripts, to force `go mod` to see them as dependencies
 package tools
-
-import (
-	_ "github.com/gobuffalo/packr/v2/packr2"
-	_ "github.com/golang/mock/mockgen"
-	_ "github.com/onsi/ginkgo/ginkgo"
-)

go.mod

@@ -15,8 +15,7 @@ require (
 	github.com/ghodss/yaml v1.0.0
 	github.com/go-logr/logr v0.1.0
 	github.com/go-openapi/spec v0.19.2
-	github.com/gobuffalo/packr v1.25.0
-	github.com/gobuffalo/packr/v2 v2.1.0
+	github.com/gobuffalo/packr v1.30.1
 	github.com/gogo/protobuf v1.3.1
 	github.com/golang/mock v1.4.3
 	github.com/googleapis/gnostic v0.3.1
@@ -38,7 +37,7 @@ require (
 	go.uber.org/zap v1.13.0
 	golang.org/x/crypto v0.0.0-20200220183623-bac4c82f6975
 	golang.org/x/lint v0.0.0-20191125180803-fdd1cda4f05f
-	golang.org/x/tools v0.0.0-20200403190813-44a64ad78b9b // indirect
+	golang.org/x/tools v0.0.0-20200406213809-066fd1390ee0 // indirect
 	gomodules.xyz/jsonpatch/v2 v2.0.1
 	google.golang.org/grpc v1.26.0
 	gopkg.in/yaml.v2 v2.2.8