-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support some extra operators #255
Conversation
To write a test, add a method to
The I'm not familiar with the extra operators you've provided---for what are they used? |
I needed support for the network operators in PostgreSQL. They are On the testing subject: I've been pondering on how to effectively test The remaining thing that needs to be tested is looking if your Its hard to test though, if SQLalchemy decides to fix something, your I wonder if no one has fixed this issue, and I suppose you must've [1] http://www.postgresql.org/docs/9.2/interactive/functions-net.html |
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't delete this new line.
Ok. Well I'd least like to see a test case that shows some sort of error response from the server if the backend is sqlite but the client has requested some of these network address operators. |
It should certainly be possible to write a test that uses PostgreSQL with SQLAlchemy; Flask-Restless (should be) backend-agnostic beyond the requirement of SQLAlchemy. Take a look at |
See pull request #502 which includes the suggestions here in addition to tests and documentation. |
Hi Jeffrey,
I've added a few operators through the .op() function that SQLalchemy provides.
I'd be delighted to create some working tests for this, but I'm afraid I don't interpret the current workings of the search test.
Thanks