Add more generic support for controllers and icon for Stadia #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfernandez
reviewed
Jan 19, 2023
backend/src/api/generic.rs
Outdated
| "discharging".to_string() | ||
| } else { | ||
| "unknown".to_string() | ||
| }, |
Owner
There was a problem hiding this comment.
So we don't detect whether the Stadia controller is charging atm?
Collaborator
Author
There was a problem hiding this comment.
Correct, I'll have to dig deeper to see if we can detect it. If so I'll update the code. For now we'll keep it to unknown
jfernandez
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should take care of duplicate controllers and filters out some devices listed by hidapi like the steam controllers (USB) and the touchpad. It might bubble up some unexpected devices though but we can filter those out maybe as needed. But at least with this we can display controllers more generically and get Stadia support working