Fix no method error on decrement when output is not TTY enabled #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling decrement when the output is not TTY enabled causes a no method error as bar_update_string returns nil where a string is expected. This change ensures a string is returned so there is no runtime error and adds a test case.
|
Awesome!!!! 😄 👍 🎉 |
jfelchner
added a commit
that referenced
this pull request
Aug 3, 2018
Why This Change Is Necessary ======================================================================== - [x] Bug Fix - [ ] New Feature Calling decrement when the output is not TTY enabled causes a no method error as `bar_update_string` returns `nil` where a string is expected. How These Changes Address the Issue ======================================================================== This change ensures a string is returned so there is no runtime error and adds a test case. Side Effects Caused By This Change ======================================================================== - [ ] This Causes a Breaking Change - [x] This Does Not Cause Any Known Side Effects Checklist ======================================================================== - [x] I have run `rubocop` against the codebase - [x] I have added tests to cover my changes - [x] All new and existing tests passed ------------------------------------------------------------------------ Github Issue URLs: * #147
|
Merged in 636672c ❤ |
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling decrement when the output is not TTY enabled causes a no method
error as bar_update_string returns nil where a string is expected. This
change ensures a string is returned so there is no runtime error and
adds a test case.