Issue #13670 - Returning ISE in all getParameter use cases outlined by Servlet 6.1 spec #14203
+383
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbartel
previously approved these changes
Dec 18, 2025
Contributor
janbartel
left a comment
janbartel
left a comment
There was a problem hiding this comment.
Looks good, niggle about the javadoc as per comment.
| /** | ||
| * <p>Exception thrown to indicate a Bad HTTP Message has either been received | ||
| * or attempted to be generated. Typically these are handled with either 400 | ||
| * or attempted to be generated. Typically, these are handled with either 400 |
Contributor
There was a problem hiding this comment.
Either doesn't make sense here unless another way of handling them other than a 400 response is listed.
Contributor
There was a problem hiding this comment.
Also, is now the only reason to keep this class is ee < 11 ?
Contributor
Author
There was a problem hiding this comment.
Now bigger than Ben Hur!
joakime
changed the title
joakime
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13670 as an alternate to #13678
Use the existing HttpException mechanism. Perhaps BadMessageException could be deprecated.
Prefer HttpException.IllegalStateException over BadMessageException, to not generate the wrong exception type in the first place.