Skip to content

make sure HttpStreamOverHTTP2.onFailure() cannot work on recycled channels #14202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lorban wants to merge 11 commits into
base: jetty-12.1.x
Choose a base branch
from
Open

make sure HttpStreamOverHTTP2.onFailure() cannot work on recycled channels #14202

lorban wants to merge 11 commits into from
+38 −21

Conversation

@lorban
Copy link
Contributor

@lorban lorban commented Dec 17, 2025 •
edited
Loading

Fixes #14135

@lorban
make sure onFailure() cannot work on recycled channels
8d83683 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban requested a review from sbordet December 17, 2025 09:32
@lorban lorban self-assigned this Dec 17, 2025
@lorban lorban added the Bug For general bugs on Jetty side label Dec 17, 2025
@lorban
simplify
dd37e88 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban
replace locked boolean with atomic
bd14cd5 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban
do not attempt to recycle if onFailure has executed
53350dd 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban
improve logging and comments
84057c7 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban moved this to 🏗 In progress in Jetty 12.1.6 Dec 17, 2025
@lorban
minor cleanup
3588e6b 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban linked an issue Dec 17, 2025 that may be closed by this pull request
Flaky test testRequestIdleTimeout with H2/H2C #14135
Open
@lorban
use a 3-state FSM to track when the http channel can be recycled or not
81fd3b7 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
sbordet
sbordet requested changes Dec 18, 2025
View reviewed changes
...-http2-server/src/main/java/org/eclipse/jetty/http2/server/internal/HttpStreamOverHTTP2.java Outdated
public Runnable onFailure(Throwable failure, Callback callback)
{
RecycleState previousState = RecycleState.changeState(_recycle, RecycleState.CANNOT_RECYCLE);
if (previousState == RecycleState.RECYCLED)
Copy link
Contributor

@sbordet sbordet Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@lorban
handle review comments
a0dc27e 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban
use AtomicBoolean as the state machine only has 2 states now
be23784 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban requested a review from sbordet December 18, 2025 15:00
@lorban
handle review comments
7afcc21 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban requested a review from sbordet December 18, 2025 15:19
sbordet
sbordet previously approved these changes Dec 18, 2025
View reviewed changes
@lorban
handle review comments
61ccc09 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbordet sbordet sbordet approved these changes

Assignees

@lorban lorban

Labels

Bug For general bugs on Jetty side

Projects

Jetty 12.1.6
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test testRequestIdleTimeout with H2/H2C

3 participants

@lorban @sbordet