Issue #14061 - Fix Alt-Svc header to use HTTP/3 connector port #14195
+163
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afarber
force-pushed
the
14061-alt-avc-port
branch
from
04d2c00 to
c23feb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14061
AltSvcCustomizerto get the port from the HTTP/3 connector instead of the HTTP/2 request's connectorgetConnector()getter toAbstractHTTP3ServerConnectionFactoryto expose the connector to subclassesPreviously, when HTTP/2 ran on port 8443 and HTTP/3 on port 8444, the Alt-Svc header incorrectly advertised
h3=":8443"instead ofh3=":8444", causing browsers to fail the HTTP/3 upgrade.