Issue #14068 - Cleanup IO.asFile on Windows #14124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Dec 3, 2025
|
|
||
| if (LOG.isDebugEnabled()) | ||
| LOG.debug("Not able to be converted to a File object: ({}) {}", fileObject.getClass().getName(), fileObject); | ||
| LOG.debug("Not able to be converted to a Path object: ({}) {}", pathObject.getClass().getName(), pathObject); |
Contributor
Author
There was a problem hiding this comment.
There's no ambiguity here with arguments and Throwable.
Contributor
There was a problem hiding this comment.
I thought we standardized on that idiom for every case, not just ambiguities with Throwables.
Contributor
Author
There was a problem hiding this comment.
It only applies to Throwables, as it eliminates the ambiguity on the last arg not having an associated referenced parameter ({}). If that Throwable happens to be null, then things to sideways with the currently buggy log4j2 implementation. (no other implementations of slf4j).
This is a recognized and accepted bug on log4j2.
sbordet
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Path to cleanup user input strings for File / Path resolution.
The Java
Fileobject cannot operate successfully with the variety of JVMs, Architectures, File Systems, and OSs out there.Only the
Pathobject has proper support for all combinations.IO.asFile(Object)IO.asPath(Object)with proper usage.IO.asPath(Object)Closes #14068