Issue #13398 - Improve LoginAuthenticators to handle Proxy-Authenticate#13452
Conversation
e9fc606 to
472f55e
Compare
sbordet
left a comment
There was a problem hiding this comment.
@znight1020 excellent work!
Please follow the few renamings that I suggested, and then we should be good to merge.
...y-core/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientAuthenticationTest.java
Outdated
Show resolved
Hide resolved
...y-core/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientAuthenticationTest.java
Outdated
Show resolved
Hide resolved
...y-core/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientAuthenticationTest.java
Outdated
Show resolved
Hide resolved
...y-core/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientAuthenticationTest.java
Outdated
Show resolved
Hide resolved
...y-core/jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientAuthenticationTest.java
Show resolved
Hide resolved
...tty-security/src/main/java/org/eclipse/jetty/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...tty-security/src/main/java/org/eclipse/jetty/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...tty-security/src/main/java/org/eclipse/jetty/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...tty-security/src/main/java/org/eclipse/jetty/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...security/src/main/java/org/eclipse/jetty/ee9/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback, @sbordet! I've implemented the requested renamings and Javadoc improvements, but before I push the changes, I had a quick question regarding |
|
@znight1020 I don't see the changes after review. |
efefd6e to
35066ed
Compare
|
Sorry for that, @sbordet. I've just pushed the requested changes now! To get the tests passing, I've temporarily updated Could you please take a look at the reasoning in that thread when you have a moment? |
35066ed to
7690cfc
Compare
sbordet
left a comment
There was a problem hiding this comment.
Just a typo in the javadocs, and fix testInfiniteAuthentication() and we should be good.
...tty-security/src/main/java/org/eclipse/jetty/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...security/src/main/java/org/eclipse/jetty/ee9/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
|
I've corrected the typo in the Javadocs and updated |
|
@znight1020 excellent work! |
c96377e to
daf4d0d
Compare
This pull request resolves issue #13398 by enhancing server-side authenticators to support proxy authentication.
Summary of Changes
Authenticator Enhancements:
BasicAuthenticator,DigestAuthenticatorandSPNEGOAuthenticatorno longer handle only hardcodedWWW-Authenticateheaders.setProxyMode(boolean)method has been added to the baseLoginAuthenticatorin bothjetty-securityandjetty-ee9-security.407challenges withProxy-Authenticateheaders and process credentials from theProxy-Authorizationheader, using new internal helper methods.Test Refactoring:
HttpClientAuthenticationTesthas been refactored to use a newprotected boolean isProxyMode()method (which defaults tofalse), allowing it to test both authentication modes.HttpClientProxyAuthenticationTestsubclass is introduced, which simply overridesisProxyMode()to returntrue, reusing the entire parent test suite for comprehensive validation of the new proxy mode.Resolves #13398