Add new rewrite rule to return response status code based on matching headers #12182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Aug 21, 2024
...e/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/ResponseHeaderRegexRule.java
Outdated
Show resolved
Hide resolved
...e/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/ResponseHeaderRegexRule.java
Outdated
Show resolved
Hide resolved
...e/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/ResponseHeaderRegexRule.java
Outdated
Show resolved
Hide resolved
...e/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/ResponseHeaderRegexRule.java
Outdated
Show resolved
Hide resolved
...e/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/ResponseHeaderRegexRule.java
Outdated
Show resolved
Hide resolved
...y-core/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/ResponseHeaderRule.java
Outdated
Show resolved
Hide resolved
| */ | ||
| public class ResponseHeaderRule extends HeaderRule | ||
| { | ||
| private int _code; |
Comment on lines
73
to
74
| if (getCode() < HttpStatus.CONTINUE_100) | ||
| return null; |
There was a problem hiding this comment.
Move check to setStatus().
Comment on lines
81
to
90
| String message = getMessage(); | ||
| if (StringUtil.isBlank(message)) | ||
| { | ||
| response.setStatus(getCode()); | ||
| callback.succeeded(); | ||
| } | ||
| else | ||
| { | ||
| Response.writeError(this, response, callback, getCode(), message); | ||
| } |
There was a problem hiding this comment.
Collapse as explained for the other rule.
pbhenson
force-pushed
the
response-header-rule
branch
from
612cfeb
to
d4dbece
Compare
|
I pushed an update including the changes you requested that are marked resolved and an initial attempt at the unit test. When I try to run the unit tests via maven at the cli I get errors? Is there something extra I need to do for this? Thanks... |
pbhenson
changed the title
sbordet
approved these changes
Aug 23, 2024
|
Don't worry about the |
|
@pbhenson thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two rewrite rules, both of which return a status code based on a header match, the first matches on exact string, the second matches on a regex.
I'd like some initial feedback on whether these are acceptable to be added and if the approach is ok. If so, I will follow up with cleaning up the javadoc and adding appropriate tests.
Thanks...