Fix missing notifyRemoteAsyncErrors http config wiring #11897

lorban · 2024-06-10T11:38:36Z

HttpConfiguration.isNotifyRemoteAsyncErrors() is not used anywhere in Jetty 12.

Fix this by adding the necessary check.

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

sbordet

Please add a test case.

…0.x/wire-isNotifyRemoteAsync

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

sbordet · 2024-06-11T16:51:53Z

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java

@@ -437,7 +437,7 @@ public Runnable onFailure(Throwable x)
                // Notify the failure listeners only once.
                Consumer<Throwable> onFailure = _onFailure;
                _onFailure = null;
-                Runnable invokeOnFailureListeners = onFailure == null ? null : () ->
+                Runnable invokeOnFailureListeners = onFailure == null || !getHttpConfiguration().isNotifyRemoteAsyncErrors() ? null : () ->


I'm not sure this is the right place to check for isNotifyRemoteAsyncErrors(), because not all errors that arrive here are remote async errors.

I'm not sure there is a way to reliably discriminate errors. Maybe this feature is specific to ee* environments?

In Jetty 11, the check for notifyRemoteAsyncErrors was done in the HTTP/2 and HTTP/3 layers, not generically.

I think we should restore that.

The idea would be to introduce an onRemoteFailure() method that is only called from H2 and H3, and have this new method delegate to onFailure() with an extra parameter, so that pending reads and writes are notified, but listeners are only invoked if the extra parameter is true.

Pushed an attempt at that; two observations:

having that notification filtering logic in core means it's not needed in ee* anymore

H3 does not have client resets?!

jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpOutput.java

...e10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannelState.java

sbordet · 2024-06-11T16:59:53Z

...ient-transports/src/test/java/org/eclipse/jetty/ee10/test/client/transport/AbstractTest.java

+    protected Session newHttp2ClientSession(Session.Listener listener) throws Exception
+    {
+        String host = "localhost";
+        int port = ((NetworkConnector)connector).getLocalPort();
+        InetSocketAddress address = new InetSocketAddress(host, port);
+        FuturePromise<Session> promise = new FuturePromise<>();
+        http2Client.connect(address, listener, promise);
+        return promise.get(5, TimeUnit.SECONDS);
+    }


No, the point of the tests in this module is to run for all transports.

This is HTTP/2 specific, so it should be moved to the jetty-http2-tests module.

I agree this isn't an idea place, but the jetty-http2-tests module is under jetty-core, it does not and cannot depend on ee10.

jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpChannelState.java

sbordet · 2024-06-11T17:01:02Z

...lient-transports/src/test/java/org/eclipse/jetty/ee9/test/client/transport/AbstractTest.java

@@ -196,6 +206,29 @@ protected void startClient(Transport transport) throws Exception
        client.start();
    }

+    protected Session newHttp2ClientSession(Session.Listener listener) throws Exception


Same as ee10.

Same response.

sbordet

See comments.

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

…0.x/wire-isNotifyRemoteAsync

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

…0.x/wire-isNotifyRemoteAsync

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

sbordet

Please remove all booleans.
Just do the instanceof EOFException in HttpStreamOverHTTP3.onFailure().

sbordet · 2024-06-17T13:42:59Z

...-server/src/main/java/org/eclipse/jetty/http2/server/internal/ServerHTTP2StreamEndPoint.java

    {
        if (LOG.isDebugEnabled())
-            LOG.debug("failure on {}", this, failure);
+            LOG.debug("{}failure on {}", remote ? "remote " : "", this, failure);


Suggested change

LOG.debug("{}failure on {}", remote ? "remote " : "", this, failure);

LOG.debug("{} failure on {}", remote ? "remote" : "local", this, failure);

sbordet · 2024-06-18T14:21:11Z

...ttp2-server/src/main/java/org/eclipse/jetty/http2/server/internal/HTTP2ServerConnection.java

    {
        if (LOG.isDebugEnabled())
-            LOG.debug("Processing stream failure on {}", stream, failure);
+            LOG.debug("Processing {}stream failure on {}", remote ? "remote " : "", stream, failure);


Suggested change

LOG.debug("Processing {}stream failure on {}", remote ? "remote " : "", stream, failure);

LOG.debug("Processing {} stream failure on {}", remote ? "remote" : "local", stream, failure);

sbordet · 2024-06-18T14:23:54Z

...ttp3/jetty-http3-client/src/main/java/org/eclipse/jetty/http3/client/ClientHTTP3Session.java

    {
-        session.onSessionFailure(error, reason, failure);
+        session.onSessionFailure(error, remote, reason, failure);


Can you keep the parameter order to be [remote, error, reason] like elsewhere?

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

(#11897) Fixed missing notifyRemoteAsyncErrors http config wiring and add tests Signed-off-by: Ludovic Orban <lorban@bitronix.be>

fix missing notifyRemoteAsyncErrors http config wiring

97f9c1d

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added the Bug For general bugs on Jetty side label Jun 10, 2024

lorban requested review from joakime and sbordet June 10, 2024 11:38

lorban self-assigned this Jun 10, 2024

lorban added the Sponsored This issue affects a user with a commercial support agreement label Jun 10, 2024

sbordet requested changes Jun 10, 2024

View reviewed changes

wendigo mentioned this pull request Jun 10, 2024

Notify AsyncContext on remote exception airlift/airlift#1186

Merged

lorban added 4 commits June 11, 2024 10:40

Merge remote-tracking branch 'origin/jetty-12.0.x' into fix/jetty-12.…

3e74543

…0.x/wire-isNotifyRemoteAsync

add tests

f10b245

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

remove ported test

2943577

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

fix checkstyle

9fbae2a

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban requested a review from sbordet June 11, 2024 14:13

rename tests

c2d4d2a

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

sbordet requested changes Jun 11, 2024

View reviewed changes

lorban requested a review from sbordet June 12, 2024 15:50

sbordet requested changes Jun 14, 2024

View reviewed changes

lorban added 3 commits June 17, 2024 10:27

handle review comments

3663281

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

Merge remote-tracking branch 'origin/jetty-12.0.x' into fix/jetty-12.…

6a64240

…0.x/wire-isNotifyRemoteAsync

move notifyRemoteAsyncErrors logic to Core API

8b35d6d

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban requested a review from sbordet June 17, 2024 09:24

lorban added 9 commits June 18, 2024 10:44

wire h3 reset

d375c8a

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

wire h3 reset

0fb278f

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

add h3 test

ceaa746

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

Merge remote-tracking branch 'origin/jetty-12.0.x' into fix/jetty-12.…

dfb2e2b

…0.x/wire-isNotifyRemoteAsync

add h3 test

09ea4e9

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

fix checkstyle

ecd9e98

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

add ee9 tests

bf492f4

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

remove unneeded code

1de023f

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

fix compilation

efc7170

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

fix doc

9229515

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

sbordet requested changes Jun 18, 2024

View reviewed changes

lorban added 2 commits June 18, 2024 17:09

rewire h3

2a63ee4

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

rewire h2

3d2f744

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban requested a review from sbordet June 18, 2024 15:27

lorban added 4 commits June 18, 2024 17:41

change wrapping in h2

3d2e2fd

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

change wrapping in h3

c0458a7

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

refactor ee* tests

a428f3c

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

refactor ee* tests

bacbabe

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

sbordet approved these changes Jun 18, 2024

View reviewed changes

lorban merged commit 9546b3a into jetty-12.0.x Jun 18, 2024
9 checks passed

lorban deleted the fix/jetty-12.0.x/wire-isNotifyRemoteAsync branch June 18, 2024 18:00

joakime added a commit that referenced this pull request Jun 19, 2024

Fix missing notifyRemoteAsyncErrors http config wiring

b1c2acf

(#11897) Fixed missing notifyRemoteAsyncErrors http config wiring and add tests Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban mentioned this pull request Jul 2, 2024

H3: rework exception handling #10583

Closed

olamy mentioned this pull request Sep 29, 2024

Jetty 12.1.x add Eclipse dash too usagee #12325

Merged

olamy mentioned this pull request Oct 17, 2024

jetty 12.1.x merge 12.0 #12400

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing notifyRemoteAsyncErrors http config wiring #11897

Fix missing notifyRemoteAsyncErrors http config wiring #11897

lorban commented Jun 10, 2024

sbordet left a comment

sbordet Jun 11, 2024

lorban Jun 12, 2024

sbordet Jun 14, 2024

lorban Jun 17, 2024

sbordet Jun 11, 2024

lorban Jun 12, 2024 •

edited

Loading

sbordet Jun 11, 2024

lorban Jun 12, 2024

sbordet left a comment

sbordet left a comment

sbordet Jun 17, 2024

sbordet Jun 18, 2024

sbordet Jun 18, 2024

	LOG.debug("{}failure on {}", remote ? "remote " : "", this, failure);
	LOG.debug("{} failure on {}", remote ? "remote" : "local", this, failure);

	LOG.debug("Processing {}stream failure on {}", remote ? "remote " : "", stream, failure);
	LOG.debug("Processing {} stream failure on {}", remote ? "remote" : "local", stream, failure);

Fix missing notifyRemoteAsyncErrors http config wiring #11897

Fix missing notifyRemoteAsyncErrors http config wiring #11897

Conversation

lorban commented Jun 10, 2024

sbordet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lorban Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbordet left a comment

Choose a reason for hiding this comment

sbordet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lorban Jun 12, 2024 •

edited

Loading