Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11220 - ContextHandler NPE protections #11318

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Issue #11220 - ContextHandler NPE protections #11318

merged 3 commits into from
Jan 25, 2024

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jan 25, 2024 •
edited
Loading

  • add protection for NPE seen during constructor initialization.
  • Test case
  • Javadoc fixes

Fixes #11220

@joakime
Issue #11220 - ContextHandler NPE protections
8e696d8 
+ add protection for NPE seen
  during constructor initialization.
+ Javadoc fixes
@joakime
Issue #11220 - Adding LoggerDebugTest
25a5bf3
@joakime joakime requested a review from gregw January 25, 2024 00:02
@joakime joakime self-assigned this Jan 25, 2024
@joakime joakime added the Bug For general bugs on Jetty side label Jan 25, 2024
@joakime joakime added this to the 12.0.x milestone Jan 25, 2024
@joakime joakime linked an issue Jan 25, 2024 that may be closed by this pull request
ContextHandler(anyHandler) NPE during .<init> logging 'because "this._vhosts" is null' #11220
Closed
@joakime joakime mentioned this pull request Jan 25, 2024
Closed
gregw
gregw previously approved these changes Jan 25, 2024
View reviewed changes
joakime
joakime commented Jan 25, 2024
View reviewed changes
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java Outdated
Comment on lines 1043 to 1044
b.append(",a=");
b.append(",a=").append(_availability);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I doubled up the ",a="!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@joakime joakime merged commit 9df827b into jetty-12.0.x Jan 25, 2024
8 checks passed
@joakime joakime deleted the fix/12.0.x/npe-contexthandler-tostring branch January 25, 2024 13:42
@lorban lorban mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.6 FROZEN
Status: ✅ Done
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.

ContextHandler(anyHandler) NPE during .<init> logging 'because "this._vhosts" is null'
2 participants
@joakime @gregw