Fixes #11282 - Deadlocks with DEBUG logging enabled in jetty-server testing. #11306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esting. Introduced AutoLock.tryLock() to use it in the toString() implementations that lock in order to retrieve a consistent state to produce the string. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
The PR build failed with a timeout in the forked process. We need to investigate to figure out if this was a fluke or if this change introduces a bug we've overlooked. |
|
The JDK21 build here failed with a timeout https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-11306/1/pipeline |
gregw
approved these changes
Jan 25, 2024
Comment on lines
+51
to
+59
| * <p>Tries to acquire the lock.</p> | ||
| * <p>Whether the lock was acquired can be tested | ||
| * with {@link #isHeldByCurrentThread()}.</p> | ||
| * <p>Typical usage of this method is in {@code toString()}, | ||
| * to avoid deadlocks when the implementation needs to lock | ||
| * to retrieve a consistent state to produce the string.</p> | ||
| * | ||
| * @return this AutoLock for unlocking | ||
| */ |
There was a problem hiding this comment.
Suggested change
| * <p>Tries to acquire the lock.</p> | |
| * <p>Whether the lock was acquired can be tested | |
| * with {@link #isHeldByCurrentThread()}.</p> | |
| * <p>Typical usage of this method is in {@code toString()}, | |
| * to avoid deadlocks when the implementation needs to lock | |
| * to retrieve a consistent state to produce the string.</p> | |
| * | |
| * @return this AutoLock for unlocking | |
| */ | |
| * <p>Tries to acquire the lock.</p> | |
| * <p>Whether the lock was acquired can be tested | |
| * with {@link #isHeldByCurrentThread()}.</p> | |
| * <p>Typical usage of this method is in {@code toString()}, | |
| * to avoid deadlocks when the implementation needs to lock | |
| * to retrieve a consistent state to produce the string.</p> | |
| * @see ReentrantLock#isHeldByCurrentThread() | |
| * @return this AutoLock for unlocking | |
| */ |
lorban
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced AutoLock.tryLock() to use it in the toString() implementations that lock in order to retrieve a consistent state to produce the string.