Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11263 - Reduce usage of glob lib/foo/*.jar in modules #11264

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Issue #11263 - Reduce usage of glob lib/foo/*.jar in modules #11264

merged 5 commits into from
Jan 16, 2024

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jan 11, 2024

  • Using @foo.version@ technique and proper lib lists to allow arbitrary version updates from properties

Closes #11263

@joakime
Issue #11263 - Reduce usage of glob lib/foo/*.jar in modules
05d0e0b 
* Using @foo.version@ technique and proper
  lib lists to allow arbitrary version
  updates from properties
@joakime joakime added Enhancement dependencies Pull requests that update a dependency file labels Jan 11, 2024
@joakime joakime added this to the 12.0.x milestone Jan 11, 2024
@joakime joakime requested review from olamy and gregw January 11, 2024 19:55
@joakime joakime self-assigned this Jan 11, 2024
@joakime joakime added the Sponsored This issue affects a user with a commercial support agreement label Jan 11, 2024
gregw
gregw previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice (assuming it builds:)

janbartel
janbartel requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the duplicate lines then looks good.

jetty-ee10/pom.xml Outdated Show resolved Hide resolved
@joakime joakime requested review from janbartel and gregw January 12, 2024 16:36
@joakime joakime merged commit 8368dee into jetty-12.0.x Jan 16, 2024
8 checks passed
@joakime joakime deleted the fix/12.0.x/start-use-of-jetty.version branch January 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbartel janbartel janbartel approved these changes

@olamy olamy Awaiting requested review from olamy

@gregw gregw Awaiting requested review from gregw

Assignees

@joakime joakime

Labels
dependencies Pull requests that update a dependency file Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.6 FROZEN
Status: ✅ Done
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.

Using jetty.version override from jetty-start does not use version for various environment libs.
3 participants
@joakime @gregw @janbartel