Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RFC7239 support in Proxy and Middleman #842

Open
gregw opened this issue Aug 15, 2016 · 11 comments · Fixed by #12352 or #12400
Open

Implement RFC7239 support in Proxy and Middleman #842

gregw opened this issue Aug 15, 2016 · 11 comments · Fixed by #12352 or #12400
Assignees
@sbordet
Labels
Enhancement Help Wanted
Milestone
9.3.x

Comments

@gregw
Copy link
Contributor

gregw commented Aug 15, 2016

Add configurable support for RFC7239 Forwarded header as an option to the defacto standard X-Forwarded-XXX headers. This should be for at least the Proxy servlet, but maybe also the Middleman.
@gregw gregw added this to the 9.3.x milestone Aug 15, 2016
@gregw
Copy link
Contributor Author

gregw commented Aug 15, 2016

See also #834 and #185

@sbordet
Copy link
Contributor

sbordet commented Aug 16, 2016

@gregw Both ProxyServlet and AsyncMiddleManServlet use X-Forwarded-XXX headers from AbstractProxyServlet.addXForwardedHeaders().

Where did you see ProxyServlet use RFC 7239 and AsyncMiddleManServlet not using those ?

@joakime joakime mentioned this issue Nov 1, 2016
Closed
@joakime
Copy link
Contributor

joakime commented Nov 1, 2016

Opened new issue specifically for AbstractNCSARequestLog, closing this one.

@joakime joakime closed this as completed Nov 1, 2016
@sbordet sbordet reopened this Nov 1, 2016
@sbordet
Copy link
Contributor

sbordet commented Nov 1, 2016

Reopening, as the mechanism for adding headers in ProxyServlet has nothing to do with AbstractNCSARequestLog.

@joakime joakime mentioned this issue Nov 1, 2016
Closed
@joakime
Copy link
Contributor

joakime commented Nov 1, 2016

@sbordet correct, this one should have remained open. I meant to close #834 instead.

@sbordet sbordet mentioned this issue Aug 14, 2019
Closed
@stale
Copy link

stale bot commented Aug 15, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Aug 15, 2020
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Aug 15, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label May 19, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label May 19, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label May 20, 2023
@sbordet
Copy link
Contributor

sbordet commented May 20, 2023

In 12, ProxyHandler uses Forwarded, while ee10's ProxyServlet uses X-Forwarded-*.
We should make ProxyServlet default on Forwarded with an option to use X-Forwarded-*.

@github-actions github-actions bot removed the Stale For auto-closed stale issues and pull requests label May 21, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label May 20, 2024
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label May 20, 2024
@sbordet
Copy link
Contributor

sbordet commented May 20, 2024

Due to change in behavior, rescheduled for 12.1.0.

@gregw gregw closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in Jetty 12.1.0 Oct 2, 2024
@gregw gregw reopened this Oct 2, 2024
sbordet added a commit that referenced this issue Oct 8, 2024
@sbordet
Fixes #842 - Implement RFC7239 support in Proxy and Middleman.
6d32b16 
Updated ee10/ee11 AbstractProxyServlet to use the `Forwarded` header rather than the now deprecated `X-Forwarded-For` headers.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Oct 8, 2024 that will close this issue
Fixes #842 - Implement RFC7239 support in Proxy and Middleman. #12352
Merged
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.1.0 Oct 8, 2024
sbordet added a commit that referenced this issue Oct 10, 2024
@sbordet
Fixes #842 - Implement RFC7239 support in Proxy and Middleman.
e9b4624 
Updated ee10/ee11 AbstractProxyServlet to use the `Forwarded` header rather than the now deprecated `X-Forwarded-For` headers.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@olamy olamy mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Enhancement Help Wanted
Projects
Jetty 12.1.0
Status: 🏗 In progress
Milestone
9.3.x
3 participants
@gregw @joakime @sbordet