Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion debug/test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
var soqlParserJs = require('../dist');

const query = `
SELECT COUNT_DISTINCT(Company) FROM Lead
SELECT Id, c.FirstName, c.LastName
FROM Contact c
LIMIT 1
`;

const parsedQuery = soqlParserJs.parseQuery(query, { logging: true });
Expand Down
8 changes: 4 additions & 4 deletions lib/SoqlComposer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class Compose {

private parseQuery(query: Query, isSubquery: boolean = false): string {
const fieldData: FieldData = {
fields: this.parseFields(query.fields, query.sObjectAlias ? true : false).map(field => ({
fields: this.parseFields(query.fields).map(field => ({
text: field,
isSubquery: false,
prefix: '',
Expand Down Expand Up @@ -170,12 +170,12 @@ export class Compose {
return output;
}

private parseFields(fields: Field[], hasSObjectAlias: boolean): string[] {
private parseFields(fields: Field[]): string[] {
return fields
.map(field => {
if (utils.isString(field.text)) {
if (hasSObjectAlias) {
return `${utils.get(field.alias, '.')}${field.text}`;
if (field.objectPrefix) {
return `${utils.get(field.objectPrefix, '.')}${field.text}`;
} else {
return `${field.text}${utils.get(field.alias, '', ' ')}`;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/SoqlListener.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export class Listener implements SOQLListener {
// All fields need to update to remove the alias from relationships
this.getSoqlQuery().fields.forEach(field => {
if (field.text && field.text.startsWith(`${ctx.text}.`)) {
field.alias = ctx.text;
field.objectPrefix = ctx.text;
field.text = field.text.replace(`${ctx.text}.`, '');
if (field.relationshipFields.length > 2) {
field.relationshipFields = field.relationshipFields.splice(1);
Expand Down
1 change: 1 addition & 0 deletions lib/models/SoqlQuery.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export interface SelectStatement {
export interface Field {
text?: string;
alias?: string;
objectPrefix?: string;
relationshipFields?: string[];
fn?: FunctionExp;
subqueryObjName?: string; // populated if subquery
Expand Down
12 changes: 6 additions & 6 deletions test/TestCases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -867,12 +867,12 @@ export const testCases: TestCase[] = [
fields: [
{
text: 'Name',
alias: 'c',
objectPrefix: 'c',
},
{
text: 'Account.Name',
relationshipFields: ['Account', 'Name'],
alias: 'c',
objectPrefix: 'c',
},
],
subqueries: [],
Expand Down Expand Up @@ -989,11 +989,11 @@ export const testCases: TestCase[] = [
fields: [
{
text: 'Id',
alias: 'a',
objectPrefix: 'a',
},
{
text: 'Name',
alias: 'a',
objectPrefix: 'a',
},
{
subqueryObjName: 'ChildAccounts',
Expand All @@ -1007,7 +1007,7 @@ export const testCases: TestCase[] = [
fields: [
{
text: 'Id',
alias: 'a2',
objectPrefix: 'a2',
},
],
subqueries: [],
Expand All @@ -1018,7 +1018,7 @@ export const testCases: TestCase[] = [
fields: [
{
text: 'Id',
alias: 'a1',
objectPrefix: 'a1',
},
],
subqueries: [],
Expand Down