Fix incorrect parsing for NOT negation #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that all `expressionNegation` entries are visited instead of just the first one in the case where there aer multiple negations in a row Removed `NOT IN` keyword in lexer to avoid false positives for identifiers (fields) that start with `In` preceded by `NOT` Enable typescript strict mode to help enforce handling data properly - this required many minor updates. Improved visitor types to better express actual shape of context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all
expressionNegationentries are visited instead of just the first one in the case where there aer multiple negations in a rowRemoved
NOT INkeyword in lexer to avoid false positives for identifiers (fields) that start withInpreceded byNOTEnable typescript strict mode to help enforce handling data properly - this required many minor updates.
Improved visitor types to better express actual shape of context
resolves #237