ESM builds fail for node environments

[tehnrd]

The esm build command does not output .mjs files. This causes build issues in projects where the package.json type is module as builders for these projects then expect the esm imports to be a .mjs file.

This is env specific, but this is the type of error I am receiving as an example:

[vite] (ssr) Error when evaluating SSR module /src/routes/monitoring/metrics/+page.svelte: [vite] Named export 'isQueryValid' not found. The requested module '@jetstreamapp/soql-parser-js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@jetstreamapp/soql-parser-js';
const {parseQuery, composeQuery, isQueryValid} = pkg;

Switching to the suggested fix in this error message does not actually resolve the issue.

[tehnrd]

@paustint would love your thoughts on this. Currently blocked being about to use this in a node js environment with type of module

[paustint]

I will take a look, I have been using with vite without issues, but it must have been a slightly different setup.

Are you having issues with node or trying to use in the browser?

And are you using typescript or JavaScript?

You said node, but the error is svelt - so any additional details would be helpful.

Thanks!

[tehnrd]

I see it was merged, but will still try to provide some clarity.

I don't 100% understand the root cause as I was more focused on the fix and not diving deep on vite configs. Vite for SvelteKit build targets ESM but I think it expects library files for esm to be .mjs. I think it was getting all mixed up as it was expecting the ESM build to be .mjs but was then somehow importing the commonjs output.

[tehnrd]

...and I broke types with this issue and related PR. This was a miss on my part 🤦🏻

#263 fix it.