Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Add docs for socket path problem #817

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Add docs for socket path problem #817

merged 2 commits into from
Jun 21, 2019

Conversation

MattiasGees
Copy link
Member

What this PR does / why we need it:
Addresses problem with long temp paths for sockets.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2019
@jetstack-bot jetstack-bot requested a review from simonswine May 31, 2019 07:19
@jetstack-bot jetstack-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 31, 2019
@MattiasGees
Add docs for socket path problem
1967905 
Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 31, 2019
@JoshVanL
Copy link
Contributor

Page looks good to me
/approve
/assign @simonswine

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
@simonswine simonswine closed this Jun 3, 2019
@simonswine simonswine reopened this Jun 3, 2019
@simonswine
Copy link
Contributor

/retest

1 similar comment
@simonswine
Copy link
Contributor

/retest

@MattiasGees MattiasGees changed the title Add docs for socket path probelm Add docs for socket path problem Jun 12, 2019
simonswine
simonswine approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, MattiasGees, simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonswine
Upgrade reference docs
e7dd356 
Signed-off-by: Christian Simon <simon@swine.de>
@jetstack-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2019
@simonswine simonswine added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@jetstack-bot jetstack-bot merged commit da0cab6 into jetstack:master Jun 21, 2019
@simonswine
Copy link
Contributor

/cherrypick release-0.6

@jetstack-bot jetstack-bot mentioned this pull request Jun 21, 2019
Merged
@jetstack-bot
Copy link
Collaborator

@simonswine: new pull request created: #820

In response to this:

/cherrypick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattiasGees @JoshVanL @simonswine @jetstack-bot