Return error on closing gcs write#93
Merged
jetstack-bot merged 1 commit intojetstack:masterfrom Feb 10, 2020
j-fuentes:avoid-masking-gcs-errors
Merged
Return error on closing gcs write#93jetstack-bot merged 1 commit intojetstack:masterfrom j-fuentes:avoid-masking-gcs-errors
jetstack-bot merged 1 commit intojetstack:masterfrom
j-fuentes:avoid-masking-gcs-errors
Conversation
jetstack-bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: j-fuentes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
approved
wwwil
requested changes
Feb 10, 2020
| } | ||
|
|
||
| return nil | ||
| return err |
Member
There was a problem hiding this comment.
Is this to keep a reference to the error in case something goes wrong in the defer? Could you add a comment to clarify this as its a bit strange.
Member
Author
There was a problem hiding this comment.
Yes, that's the reason.
I have added a comment.
Signed-off-by: Jose Fuentes <jsfuentescastillo@gmail.com>
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.