[VC-45997] Fix agent version by adding gomodule_name to handle go module / repo mismatch#733
Merged
[VC-45997] Fix agent version by adding gomodule_name to handle go module / repo mismatch#733
Conversation
- Add gomodule_name and use it for ldflags and golangci-lint config - Update makefiles to reference gomodule_name instead of repo_name - Add TODO in go.mod to track renaming the Go module to match repo Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj-cyberark
changed the title
wallrj-cyberark
changed the title
make/ark/00_mod.mk
Outdated
| -X $(repo_name)/pkg/version.BuildDate=$(shell date "+%F-%T-%Z") \ | ||
| -X $(gomodule_name)/pkg/version.PreflightVersion=$(VERSION) \ | ||
| -X $(gomodule_name)/pkg/version.Commit=$(GITCOMMIT) \ | ||
| -X $(gomodule_name)/pkg/version.BuildDate=$(shell date "+%F-%T-%Z") \ |
Collaborator
There was a problem hiding this comment.
Extra \ at the end.
mladen-rusev-cyberark
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://venafi.atlassian.net/browse/VC-45997
Testing