[VC-35565] Automate the e2e script to run in CI#716
Merged
mladen-rusev-cyberark merged 10 commits intomasterfrom Sep 17, 2025
Merged
[VC-35565] Automate the e2e script to run in CI#716mladen-rusev-cyberark merged 10 commits intomasterfrom
mladen-rusev-cyberark merged 10 commits intomasterfrom
Conversation
wallrj-cyberark
approved these changes
Sep 16, 2025
Member
wallrj-cyberark
left a comment
There was a problem hiding this comment.
A few suggestions for things to be addressed now or in future PRs.
added 8 commits
September 17, 2025 12:35
* add venctl and step as tools * reduce log level * add controls based on MR labels
wallrj-cyberark
approved these changes
Sep 17, 2025
Member
wallrj-cyberark
left a comment
There was a problem hiding this comment.
Thanks @mladen-rusev-cyberark
Lets merge this and try it out and improve it in future PRs.
For example, I think we should probable add some labels to the GKE cluster so that the security team using Wiz.io can trace this back to our team and understand the purpose of the cluster.
Also have no idea how we are going to turn on coverage instrumentation in the agent binary and then copy the coverage report back from the agent running in this remote cluster.
| ## @category Testing | ||
| test-e2e-gke: | ||
| test-e2e-gke: | $(NEEDS_HELM) $(NEEDS_STEP) $(NEEDS_VENCTL) | ||
| ./hack/e2e/test.sh |
Member
There was a problem hiding this comment.
So does makefile-modules automatically add _bin/tools to the PATH?
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCP_SA_KEYtest-e2eandkeep-e2e-cluster- one to trigger the e2e test and the other to keep the cluster alive in GKE for debugging.Closes https://venafi.atlassian.net/browse/VC-35565