fix(datareading): improve DataReading JSON parsing and error handling#710
Merged
wallrj-cyberark merged 1 commit intomasterfrom Sep 5, 2025
Merged
Conversation
- Refactor UnmarshalJSON to use prioritized type decoding for Data field - Add strict unmarshalling helper to disallow unknown fields - Return errors for empty or unknown data types in Data field - Add unit tests for valid and invalid JSON scenarios Signed-off-by: Richard Wall <richard.wall@cyberark.com>
mladen-rusev-cyberark
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements to the UnmarshalJSON function (which was introduced in #707):
Testing
The "echo server" test was using a arbitrary data type, which is no longer allowed, so I switched it to DataReading. Here's the output of the updated test:
The machinehub outputmode test still works: