Implement WriteIndex for cluster summaries#70
Merged
jetstack-bot merged 3 commits intojetstack:masterfrom Jan 30, 2020
charlieegan3:write-report-index
Merged
Implement WriteIndex for cluster summaries#70jetstack-bot merged 3 commits intojetstack:masterfrom charlieegan3:write-report-index
jetstack-bot merged 3 commits intojetstack:masterfrom
charlieegan3:write-report-index
Conversation
jetstack-bot
added
the
dco-signoff: yes
jetstack-bot
added
approved
j-fuentes
approved these changes
Jan 30, 2020
| } | ||
|
|
||
| // build a report to build the updated context for the report index | ||
| report, err := reports.NewReport(manifest, rc) |
Member
There was a problem hiding this comment.
Possible optimization: We don't really need the whole report here. We could create here the ReportSummary.
But that's is not a reason to block this PR.
Contributor
Author
There was a problem hiding this comment.
Yeah... I did wonder about this... it's not ideal.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charlieegan3, j-fuentes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
needs-rebase
Member
|
/lgtm |
jetstack-bot
added
lgtm
Contributor
Author
|
I had to rebase and fix a failed test... |
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Member
|
/lgtm |
This was referenced Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #54